| Message ID | dda85a5e41fbb1995fe3bda810a7a8297ccf1dcb.1390370582.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 22 January 2014 11:34, Viresh Kumar <viresh.kumar@linaro.org> wrote: > Double ! or !! are normally required to get 0 or 1 out of a expression. A > comparision always returns 0 or 1 and hence there is no need to apply double ! > over it again. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > kernel/power/suspend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c > index 62ee437..90b3d93 100644 > --- a/kernel/power/suspend.c > +++ b/kernel/power/suspend.c > @@ -39,7 +39,7 @@ static const struct platform_suspend_ops *suspend_ops; > > static bool need_suspend_ops(suspend_state_t state) > { > - return !!(state > PM_SUSPEND_FREEZE); > + return state > PM_SUSPEND_FREEZE; > } > > static DECLARE_WAIT_QUEUE_HEAD(suspend_freeze_wait_head); Ping!!
diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index 62ee437..90b3d93 100644 --- a/kernel/power/suspend.c +++ b/kernel/power/suspend.c @@ -39,7 +39,7 @@ static const struct platform_suspend_ops *suspend_ops; static bool need_suspend_ops(suspend_state_t state) { - return !!(state > PM_SUSPEND_FREEZE); + return state > PM_SUSPEND_FREEZE; } static DECLARE_WAIT_QUEUE_HEAD(suspend_freeze_wait_head);
Double ! or !! are normally required to get 0 or 1 out of a expression. A comparision always returns 0 or 1 and hence there is no need to apply double ! over it again. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- kernel/power/suspend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)