[v4,3/3] doc: update deprecation of CIO barrier APIs

Message ID 20200706234333.26310-3-honnappa.nagarahalli@arm.com
State New
Headers show
Series
  • [v4,1/3] eal: adjust barriers for IO on Armv8-a
Related show

Commit Message

Honnappa Nagarahalli July 6, 2020, 11:43 p.m.
rte_cio_*mb APIs will be deprecated in 20.11 release.

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>

---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.17.1

Comments

David Marchand July 7, 2020, 8:39 a.m. | #1
On Tue, Jul 7, 2020 at 1:44 AM Honnappa Nagarahalli
<honnappa.nagarahalli@arm.com> wrote:
>

> rte_cio_*mb APIs will be deprecated in 20.11 release.

>

> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> Acked-by: Jerin Jacob <jerinj@marvell.com>

> ---

>  doc/guides/rel_notes/deprecation.rst | 6 ++++++

>  1 file changed, 6 insertions(+)

>

> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst

> index d1034f60f..59656da3d 100644

> --- a/doc/guides/rel_notes/deprecation.rst

> +++ b/doc/guides/rel_notes/deprecation.rst

> @@ -40,6 +40,12 @@ Deprecation Notices

>    These wrappers must be used for patches that need to be merged in 20.08

>    onwards. This change will not introduce any performance degradation.

>

> +* rte_cio_*mb: Since the IO barriers for ArmV8-a platforms are relaxed from DSB

> +  to DMB, rte_cio_*mb APIs provide the same functionality as rte_io_*mb

> +  APIs(taking all platforms into consideration). rte_io_*mb APIs should be used


Nit: missing space.


> +  in the place of rte_cio_*mb APIs. The rte_cio_*mb APIs will be deprecated in

> +  20.11 release.

> +

>  * igb_uio: In the view of reducing the kernel dependency from the main tree,

>    as a first step, the Technical Board decided to move ``igb_uio``

>    kernel module to the dpdk-kmods repository in the /linux/igb_uio/ directory

> --

> 2.17.1

>


LGTM.

We need 3 acks (ideally from different vendors/companies) for a
deprecation notice.
Please maintainers?


Thanks.

-- 
David Marchand
David Christensen July 7, 2020, 8:14 p.m. | #2
On 7/6/20 4:43 PM, Honnappa Nagarahalli wrote:
> rte_cio_*mb APIs will be deprecated in 20.11 release.

> 

> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> Acked-by: Jerin Jacob <jerinj@marvell.com>

> ---

>   doc/guides/rel_notes/deprecation.rst | 6 ++++++

>   1 file changed, 6 insertions(+)

> 

> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst

> index d1034f60f..59656da3d 100644

> --- a/doc/guides/rel_notes/deprecation.rst

> +++ b/doc/guides/rel_notes/deprecation.rst

> @@ -40,6 +40,12 @@ Deprecation Notices

>     These wrappers must be used for patches that need to be merged in 20.08

>     onwards. This change will not introduce any performance degradation.

> 

> +* rte_cio_*mb: Since the IO barriers for ArmV8-a platforms are relaxed from DSB

> +  to DMB, rte_cio_*mb APIs provide the same functionality as rte_io_*mb

> +  APIs(taking all platforms into consideration). rte_io_*mb APIs should be used

> +  in the place of rte_cio_*mb APIs. The rte_cio_*mb APIs will be deprecated in

> +  20.11 release.

> +


No difference between rte_cio_* and rte_io_* macros on PPC.

Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
David Marchand July 8, 2020, 11:49 a.m. | #3
On Tue, Jul 7, 2020 at 1:44 AM Honnappa Nagarahalli
<honnappa.nagarahalli@arm.com> wrote:
>

> rte_cio_*mb APIs will be deprecated in 20.11 release.

>

> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> Acked-by: Jerin Jacob <jerinj@marvell.com>

Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>

Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>


Series applied, thanks.


-- 
David Marchand

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d1034f60f..59656da3d 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -40,6 +40,12 @@  Deprecation Notices
   These wrappers must be used for patches that need to be merged in 20.08
   onwards. This change will not introduce any performance degradation.
 
+* rte_cio_*mb: Since the IO barriers for ArmV8-a platforms are relaxed from DSB
+  to DMB, rte_cio_*mb APIs provide the same functionality as rte_io_*mb
+  APIs(taking all platforms into consideration). rte_io_*mb APIs should be used
+  in the place of rte_cio_*mb APIs. The rte_cio_*mb APIs will be deprecated in
+  20.11 release.
+
 * igb_uio: In the view of reducing the kernel dependency from the main tree,
   as a first step, the Technical Board decided to move ``igb_uio``
   kernel module to the dpdk-kmods repository in the /linux/igb_uio/ directory