[v2] rawdev: fix to remove EXPERIMENTAL from comment

Message ID 20200707085407.12555-1-hemant.agrawal@nxp.com
State New
Headers show
Series
  • [v2] rawdev: fix to remove EXPERIMENTAL from comment
Related show

Commit Message

Hemant Agrawal July 7, 2020, 8:54 a.m.
The experimental tags were removed, but the comment
is still having API classification as EXPERIMENTAL

Fixes: 931cc531aad2 ("rawdev: remove experimental tag")
Cc: stable@dpdk.org

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

---
 MAINTAINERS                        | 2 +-
 lib/librte_rawdev/rte_rawdev.h     | 3 ---
 lib/librte_rawdev/rte_rawdev_pmd.h | 3 ---
 3 files changed, 1 insertion(+), 7 deletions(-)

-- 
2.17.1

Comments

Thomas Monjalon July 7, 2020, 9:02 a.m. | #1
07/07/2020 10:54, Hemant Agrawal:
> The experimental tags were removed, but the comment

> is still having API classification as EXPERIMENTAL

> 

> Fixes: 931cc531aad2 ("rawdev: remove experimental tag")

> Cc: stable@dpdk.org

> 

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> ---

>  MAINTAINERS                        | 2 +-

>  lib/librte_rawdev/rte_rawdev.h     | 3 ---

>  lib/librte_rawdev/rte_rawdev_pmd.h | 3 ---

>  3 files changed, 1 insertion(+), 7 deletions(-)


Acked-by: Thomas Monjalon <thomas@monjalon.net>
Ferruh Yigit July 7, 2020, 9:08 a.m. | #2
On 7/7/2020 10:02 AM, Thomas Monjalon wrote:
> 07/07/2020 10:54, Hemant Agrawal:

>> The experimental tags were removed, but the comment

>> is still having API classification as EXPERIMENTAL

>>

>> Fixes: 931cc531aad2 ("rawdev: remove experimental tag")

>> Cc: stable@dpdk.org

>>

>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

>> ---

>>  MAINTAINERS                        | 2 +-

>>  lib/librte_rawdev/rte_rawdev.h     | 3 ---

>>  lib/librte_rawdev/rte_rawdev_pmd.h | 3 ---

>>  3 files changed, 1 insertion(+), 7 deletions(-)

> 

> Acked-by: Thomas Monjalon <thomas@monjalon.net>

> 


It seems the APIs are already part of stable API, +1 to update the documentation
to match it.

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
David Marchand July 7, 2020, 9:13 a.m. | #3
On Tue, Jul 7, 2020 at 10:58 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>

> The experimental tags were removed, but the comment

> is still having API classification as EXPERIMENTAL

>

> Fixes: 931cc531aad2 ("rawdev: remove experimental tag")

> Cc: stable@dpdk.org

>

> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> ---

>  MAINTAINERS                        | 2 +-

>  lib/librte_rawdev/rte_rawdev.h     | 3 ---

>  lib/librte_rawdev/rte_rawdev_pmd.h | 3 ---

>  3 files changed, 1 insertion(+), 7 deletions(-)

>

> diff --git a/MAINTAINERS b/MAINTAINERS

> index 27fcd6d648..6ba02d73aa 100644

> --- a/MAINTAINERS

> +++ b/MAINTAINERS

> @@ -490,7 +490,7 @@ F: lib/librte_eventdev/*crypto_adapter*

>  F: app/test/test_event_crypto_adapter.c

>  F: doc/guides/prog_guide/event_crypto_adapter.rst

>

> -Raw device API - EXPERIMENTAL

> +Raw device API

>  M: Nipun Gupta <nipun.gupta@nxp.com>

>  M: Hemant Agrawal <hemant.agrawal@nxp.com>

>  F: lib/librte_rawdev/

> diff --git a/lib/librte_rawdev/rte_rawdev.h b/lib/librte_rawdev/rte_rawdev.h

> index ed011ca228..7a1f3213e9 100644

> --- a/lib/librte_rawdev/rte_rawdev.h

> +++ b/lib/librte_rawdev/rte_rawdev.h

> @@ -12,9 +12,6 @@

>   *

>   * This API allow applications to configure and use generic devices having

>   * no specific type already available in DPDK.

> - *

> - * @warning

> - * @b EXPERIMENTAL: this API may change without prior notice

>   */

>

>  #ifdef __cplusplus

> diff --git a/lib/librte_rawdev/rte_rawdev_pmd.h b/lib/librte_rawdev/rte_rawdev_pmd.h

> index cb3555ab50..4395a2182d 100644

> --- a/lib/librte_rawdev/rte_rawdev_pmd.h

> +++ b/lib/librte_rawdev/rte_rawdev_pmd.h

> @@ -11,9 +11,6 @@

>   * @note

>   * Driver facing APIs for a raw device. These are not to be called directly by

>   * any application.

> - *

> - * @warning

> - * @b EXPERIMENTAL: this API may change without prior notice

>   */

>

>  #ifdef __cplusplus

> --

> 2.17.1

>


Acked-by: David Marchand <david.marchand@redhat.com>



-- 
David Marchand
Thomas Monjalon July 7, 2020, 10:56 a.m. | #4
07/07/2020 11:13, David Marchand:
> On Tue, Jul 7, 2020 at 10:58 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> >

> > The experimental tags were removed, but the comment

> > is still having API classification as EXPERIMENTAL

> >

> > Fixes: 931cc531aad2 ("rawdev: remove experimental tag")

> > Cc: stable@dpdk.org

> >

> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> 

> Acked-by: David Marchand <david.marchand@redhat.com>


Applied, thanks

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 27fcd6d648..6ba02d73aa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -490,7 +490,7 @@  F: lib/librte_eventdev/*crypto_adapter*
 F: app/test/test_event_crypto_adapter.c
 F: doc/guides/prog_guide/event_crypto_adapter.rst
 
-Raw device API - EXPERIMENTAL
+Raw device API
 M: Nipun Gupta <nipun.gupta@nxp.com>
 M: Hemant Agrawal <hemant.agrawal@nxp.com>
 F: lib/librte_rawdev/
diff --git a/lib/librte_rawdev/rte_rawdev.h b/lib/librte_rawdev/rte_rawdev.h
index ed011ca228..7a1f3213e9 100644
--- a/lib/librte_rawdev/rte_rawdev.h
+++ b/lib/librte_rawdev/rte_rawdev.h
@@ -12,9 +12,6 @@ 
  *
  * This API allow applications to configure and use generic devices having
  * no specific type already available in DPDK.
- *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
  */
 
 #ifdef __cplusplus
diff --git a/lib/librte_rawdev/rte_rawdev_pmd.h b/lib/librte_rawdev/rte_rawdev_pmd.h
index cb3555ab50..4395a2182d 100644
--- a/lib/librte_rawdev/rte_rawdev_pmd.h
+++ b/lib/librte_rawdev/rte_rawdev_pmd.h
@@ -11,9 +11,6 @@ 
  * @note
  * Driver facing APIs for a raw device. These are not to be called directly by
  * any application.
- *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
  */
 
 #ifdef __cplusplus