[v2,2/5] cpuidle: psci: Fail cpuidle registration if set OSI mode failed

Message ID 20200707125804.13030-3-ulf.hansson@linaro.org
State New
Headers show
  • cpuidle: psci: Various improvements for PSCI PM domains
Related show

Commit Message

Ulf Hansson July 7, 2020, 12:58 p.m.
Currently we allow the cpuidle driver registration to succeed, even if we
failed to enable the OSI mode when the hierarchical DT layout is used. This
means running in a degraded mode, by using the available idle states per
CPU, while also preventing the domain idle states.

Moving forward, this behaviour looks quite questionable to maintain, as
complexity seems to grow around it, especially when trying to add support
for deferred probe, for example.

Therefore, let's make the cpuidle driver registration to fail in this
situation, thus relying on the default architectural cpuidle backend for
WFI to be used.

Reviewed-by: Lina Iyer <ilina@codeaurora.org>

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

 drivers/cpuidle/cpuidle-psci-domain.c | 5 -----
 1 file changed, 5 deletions(-)



diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
index 423f03bbeb74..f07786aad673 100644
--- a/drivers/cpuidle/cpuidle-psci-domain.c
+++ b/drivers/cpuidle/cpuidle-psci-domain.c
@@ -26,7 +26,6 @@  struct psci_pd_provider {
 static LIST_HEAD(psci_pd_providers);
-static bool osi_mode_enabled __initdata;
 static int psci_pd_power_off(struct generic_pm_domain *pd)
@@ -272,7 +271,6 @@  static int __init psci_idle_init_domains(void)
 		goto remove_pd;
-	osi_mode_enabled = true;
 	pr_info("Initialized CPU PM domain topology\n");
 	return pd_count;
@@ -293,9 +291,6 @@  struct device __init *psci_dt_attach_cpu(int cpu)
 	struct device *dev;
-	if (!osi_mode_enabled)
-		return NULL;
 	dev = dev_pm_domain_attach_by_name(get_cpu_device(cpu), "psci");
 	if (IS_ERR_OR_NULL(dev))
 		return dev;