From patchwork Tue Jul 7 15:05:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Garg X-Patchwork-Id: 235014 Delivered-To: patches@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp997385ilg; Tue, 7 Jul 2020 08:05:47 -0700 (PDT) X-Received: by 2002:a17:902:ed13:: with SMTP id b19mr37196524pld.294.1594134347366; Tue, 07 Jul 2020 08:05:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594134347; cv=none; d=google.com; s=arc-20160816; b=B2+rQV7gkA4QKDO4SeAgaaaskYOlVptA8CC2XpTcYEdptgPhQ7cUbr6R2tO1RHbFR4 LCks07f8p9uktplZkMizf7C1sHdseSaTnkWi6+ALbDkD5eFU0XthBoUbYo89uR/dSwck Nj1W2zjl9IckWoDYGn4fibg4Ll9IiJIjOaP6VWShClfxviWD7xG8NEnaOy6CAQW3t/RD kAlepMGT6an7I+88dHhf0nzEcf8SHNaLAZn/Ko7zXU8O9ccs2UN+QWVe26X9dueZoqsB HUFxarfGASmdE4ZQf0NPd5ZW2zHUuJYwbLfCatXCAp/kMGYTfilUUPAbR+eTSyHddIOh K0Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=wxHIhBMETpDFFxgUbCHxQv41vIYY+Vv4oIYlRuwNjXQ=; b=rodsNlhi6IqbyVxnwY4yRjISKzvoFwyvy/gROh1EoMJLSI410Fl+VjY/DH1N4t4L6j E5aKJ2mOWe9JM/hiVeA2h/gKl+IjckEPvii+TKXqNBX24V2UdhvEko6thN2kMLhJncvm 4fbsTa3G0GWVXJu2+ny2LNpVJjGJuZGksibxGFy3kUce3Dj+IX1/lRl9GSIGz9oxuq4g bf/uB5wpzxGVpKfL150IklO/jnMSxSP6K6nhIXDfqKF3YMp+Y6O0KV+ubTCiXyoVl65R iVWoSys6opGA7aKedUKvkXV2jxUpwhkkCCATDblbPpgIg6CHURSRzJf+jdRfpN52J+Tg 8vpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=N5XP1VDK; spf=pass (google.com: domain of sumit.garg@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u1sor3630678pjy.2.2020.07.07.08.05.47 for (Google Transport Security); Tue, 07 Jul 2020 08:05:47 -0700 (PDT) Received-SPF: pass (google.com: domain of sumit.garg@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=N5XP1VDK; spf=pass (google.com: domain of sumit.garg@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=sumit.garg@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=wxHIhBMETpDFFxgUbCHxQv41vIYY+Vv4oIYlRuwNjXQ=; b=N5XP1VDKrzTRRTQffSMCEiDl4kJa6K4DJFemEnlFJC/nh/Zikof+nCDhQtrGEXv1/n L8NzMDXU0Ni+b9fu6FQwANFVm1AAdbg7Sz1FMoHeW76vhUSw0KrsMpx25N+FA0MZnOCI kfw0cGJKi8Gs36wGpnCg1OTW3G0W/THROSqPxzt4Dnc1eOfIVWum9ZKUCGDZwoo90wMj V+Q4qYnsgJIsKHjISZlNEDJ3cbWzLKSYwbiI0yXuHViLOPTOg/pbKEItZCJb31hRpqE3 d7lLFv3v7BiUTvkmgV9oxFWNfXMqrTbSC/Jf6PlkYLzmfAa8bxDIV6j12ctgiFxyU23o KHqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wxHIhBMETpDFFxgUbCHxQv41vIYY+Vv4oIYlRuwNjXQ=; b=OxBvKXiVUMvnvapxA9qBM90yH0uNlgnW+qdwWGPa0ZV7x3vS6DI4vrCTtUmFL5WMV6 c3qhp6sDaHAayAFMKwudUiGFahJMkYeSVHzXAkn6fn+xc0uLFF/UfOH4eBzz+TcVKZpa ncGDBxIkhky1qdhvJ+IV0lyUxjQ1vbqaiJch2BtJi5GKguE1FmMreSMfzU6+Jpw6OIvB zr1GC+DK8F5g52N3sC7gTCPPuaVzYrbF9D8ITGcoQ5c9sJgRWloX3eJQhXUQCOji38PE Q6Am+h4JL5W8hywNGRsjHcqz+5bJ2e+IYBcCnrD3ngk6jURFQQmuLRbwJAnm2Fm+K1mb GDsQ== X-Gm-Message-State: AOAM5309Bs7gsaHqXemLMd3v7muD0hc/+EuIFSTrdL2b048a+8VsOG// aHzXCxIIgc64zW1VeLJOn3YsuCyo X-Google-Smtp-Source: ABdhPJyW8kB21rCd0YAA3f6lbpfx/X8mmVWf7a3lkugjjCIFylJsJ6NalMZ+713zVoLeRkNpBSVPqA== X-Received: by 2002:a17:90b:120a:: with SMTP id gl10mr4615735pjb.44.1594134346917; Tue, 07 Jul 2020 08:05:46 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([117.252.67.186]) by smtp.gmail.com with ESMTPSA id y18sm23400656pff.10.2020.07.07.08.05.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jul 2020 08:05:46 -0700 (PDT) From: Sumit Garg To: daniel.thompson@linaro.org Cc: patches@linaro.org, Sumit Garg Subject: [RFC INTERNAL 1/2] tty/sysrq: Make sysrq handler NMI aware Date: Tue, 7 Jul 2020 20:35:24 +0530 Message-Id: <1594134325-7912-1-git-send-email-sumit.garg@linaro.org> X-Mailer: git-send-email 2.7.4 With the advent of pseudo NMIs on arm64 its been possible to raise serial device interrupt as an NMI in polling mode. With that its now possible to do a magic sysrq in NMI context rather than in normal IRQ context. So make sysrq handler NMI aware and allow system requests to be marked as NMI safe which can run directly in NMI context while categorized as not being NMI safe will be queued as irq_work for later processing in normal interrupt context. This feature is especially helpful in case the primary CPU is stuck in deadlock with interrupts disabled won't honour serial device interrupt. So with sysrq running in NMI context is helpful to debug such scenarios. Signed-off-by: Sumit Garg --- drivers/tty/sysrq.c | 36 +++++++++++++++++++++++++++++++++++- include/linux/sysrq.h | 1 + kernel/debug/debug_core.c | 1 + 3 files changed, 37 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 7c95afa9..97393c7 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c @@ -50,6 +50,8 @@ #include #include #include +#include +#include #include #include @@ -111,6 +113,7 @@ static const struct sysrq_key_op sysrq_loglevel_op = { .help_msg = "loglevel(0-9)", .action_msg = "Changing Loglevel", .enable_mask = SYSRQ_ENABLE_LOG, + .nmi_safe = true, }; #ifdef CONFIG_VT @@ -157,6 +160,7 @@ static const struct sysrq_key_op sysrq_crash_op = { .help_msg = "crash(c)", .action_msg = "Trigger a crash", .enable_mask = SYSRQ_ENABLE_DUMP, + .nmi_safe = true, }; static void sysrq_handle_reboot(int key) @@ -170,6 +174,7 @@ static const struct sysrq_key_op sysrq_reboot_op = { .help_msg = "reboot(b)", .action_msg = "Resetting", .enable_mask = SYSRQ_ENABLE_BOOT, + .nmi_safe = true, }; const struct sysrq_key_op *__sysrq_reboot_op = &sysrq_reboot_op; @@ -217,6 +222,7 @@ static const struct sysrq_key_op sysrq_showlocks_op = { .handler = sysrq_handle_showlocks, .help_msg = "show-all-locks(d)", .action_msg = "Show Locks Held", + .nmi_safe = true, }; #else #define sysrq_showlocks_op (*(const struct sysrq_key_op *)NULL) @@ -289,6 +295,7 @@ static const struct sysrq_key_op sysrq_showregs_op = { .help_msg = "show-registers(p)", .action_msg = "Show Regs", .enable_mask = SYSRQ_ENABLE_DUMP, + .nmi_safe = true, }; static void sysrq_handle_showstate(int key) @@ -326,6 +333,7 @@ static const struct sysrq_key_op sysrq_ftrace_dump_op = { .help_msg = "dump-ftrace-buffer(z)", .action_msg = "Dump ftrace buffer", .enable_mask = SYSRQ_ENABLE_DUMP, + .nmi_safe = true, }; #else #define sysrq_ftrace_dump_op (*(const struct sysrq_key_op *)NULL) @@ -538,6 +546,26 @@ static void __sysrq_put_key_op(int key, const struct sysrq_key_op *op_p) sysrq_key_table[i] = op_p; } +#define SYSRQ_NMI_FIFO_SIZE 64 +static DEFINE_KFIFO(sysrq_nmi_fifo, int, SYSRQ_NMI_FIFO_SIZE); + +static void sysrq_do_nmi_work(struct irq_work *work) +{ + struct sysrq_key_op *op_p; + int key; + + if (!kfifo_len(&sysrq_nmi_fifo)) + return; + + while (kfifo_out(&sysrq_nmi_fifo, &key, 1)) { + op_p = __sysrq_get_key_op(key); + if (op_p) + op_p->handler(key); + } +} + +static DEFINE_IRQ_WORK(sysrq_nmi_work, sysrq_do_nmi_work); + void __handle_sysrq(int key, bool check_mask) { const struct sysrq_key_op *op_p; @@ -568,7 +596,13 @@ void __handle_sysrq(int key, bool check_mask) if (!check_mask || sysrq_on_mask(op_p->enable_mask)) { pr_info("%s\n", op_p->action_msg); console_loglevel = orig_log_level; - op_p->handler(key); + + if (in_nmi() && !op_p->nmi_safe) { + kfifo_in(&sysrq_nmi_fifo, &key, 1); + irq_work_queue(&sysrq_nmi_work); + } else { + op_p->handler(key); + } } else { pr_info("This sysrq operation is disabled.\n"); console_loglevel = orig_log_level; diff --git a/include/linux/sysrq.h b/include/linux/sysrq.h index 3a582ec..630b5b9 100644 --- a/include/linux/sysrq.h +++ b/include/linux/sysrq.h @@ -34,6 +34,7 @@ struct sysrq_key_op { const char * const help_msg; const char * const action_msg; const int enable_mask; + const bool nmi_safe; }; #ifdef CONFIG_MAGIC_SYSRQ diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c index 9e59347..2b51173 100644 --- a/kernel/debug/debug_core.c +++ b/kernel/debug/debug_core.c @@ -943,6 +943,7 @@ static const struct sysrq_key_op sysrq_dbg_op = { .handler = sysrq_handle_dbg, .help_msg = "debug(g)", .action_msg = "DEBUG", + .nmi_safe = true, }; #endif