[v3,09/13] ASoC: ti: omap-mcbsp-st: Remove set, but unused variable 'w'

Message ID 20200707190612.97799-10-pierre-louis.bossart@linux.intel.com
State New
Headers show
Series
  • Untitled series #44429
Related show

Commit Message

Pierre-Louis Bossart July 7, 2020, 7:06 p.m.
From: Lee Jones <lee.jones@linaro.org>


Looks like 'w' has remained unchecked since the driver's inception.

Fixes the following W=1 kernel build warning(s):

 sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’:
 sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-variable]

Peter suggested that the whole read can be removed, so that's
been done too.

Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: Samuel Ortiz <samuel.ortiz@nokia.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

---
 sound/soc/ti/omap-mcbsp-st.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.25.1

Comments

Peter Ujfalusi July 8, 2020, 5:39 a.m. | #1
On 07/07/2020 22.06, Pierre-Louis Bossart wrote:
> From: Lee Jones <lee.jones@linaro.org>

> 

> Looks like 'w' has remained unchecked since the driver's inception.

> 

> Fixes the following W=1 kernel build warning(s):

> 

>  sound/soc/ti/omap-mcbsp-st.c: In function ‘omap_mcbsp_st_chgain’:

>  sound/soc/ti/omap-mcbsp-st.c:145:6: warning: variable ‘w’ set but not used [-Wunused-but-set-variable]

> 

> Peter suggested that the whole read can be removed, so that's

> been done too.


Thank you,

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>


> 

> Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>

> Cc: Samuel Ortiz <samuel.ortiz@nokia.com>

> Cc: linux-omap@vger.kernel.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---

>  sound/soc/ti/omap-mcbsp-st.c | 3 ---

>  1 file changed, 3 deletions(-)

> 

> diff --git a/sound/soc/ti/omap-mcbsp-st.c b/sound/soc/ti/omap-mcbsp-st.c

> index 5a32b54bbf3b..0bc7d26c660a 100644

> --- a/sound/soc/ti/omap-mcbsp-st.c

> +++ b/sound/soc/ti/omap-mcbsp-st.c

> @@ -142,11 +142,8 @@ static void omap_mcbsp_st_fir_write(struct omap_mcbsp *mcbsp, s16 *fir)

>  

>  static void omap_mcbsp_st_chgain(struct omap_mcbsp *mcbsp)

>  {

> -	u16 w;

>  	struct omap_mcbsp_st_data *st_data = mcbsp->st_data;

>  

> -	w = MCBSP_ST_READ(mcbsp, SSELCR);

> -

>  	MCBSP_ST_WRITE(mcbsp, SGAINCR, ST_CH0GAIN(st_data->ch0gain) |

>  		       ST_CH1GAIN(st_data->ch1gain));

>  }

> 


- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Patch

diff --git a/sound/soc/ti/omap-mcbsp-st.c b/sound/soc/ti/omap-mcbsp-st.c
index 5a32b54bbf3b..0bc7d26c660a 100644
--- a/sound/soc/ti/omap-mcbsp-st.c
+++ b/sound/soc/ti/omap-mcbsp-st.c
@@ -142,11 +142,8 @@  static void omap_mcbsp_st_fir_write(struct omap_mcbsp *mcbsp, s16 *fir)
 
 static void omap_mcbsp_st_chgain(struct omap_mcbsp *mcbsp)
 {
-	u16 w;
 	struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
 
-	w = MCBSP_ST_READ(mcbsp, SSELCR);
-
 	MCBSP_ST_WRITE(mcbsp, SGAINCR, ST_CH0GAIN(st_data->ch0gain) |
 		       ST_CH1GAIN(st_data->ch1gain));
 }