From patchwork Mon Jul 13 14:49:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 235431 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp2906064ilg; Mon, 13 Jul 2020 07:49:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrpXKQi45sWE2JHJTQmQTXIVcIgI098xrLholUUT2VgtG37QwWXICDnF6/qXMdVWsrvNZk X-Received: by 2002:a17:906:86d4:: with SMTP id j20mr192750ejy.68.1594651790632; Mon, 13 Jul 2020 07:49:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594651790; cv=none; d=google.com; s=arc-20160816; b=ckGJgkiDvqCe0Mx43XslcjFJeEhu9JxozAN4Q/uvfh4odH71Iv+D7UkOJ+S50+bM8N ByY1Bj8jzsKcuisP0Mz0wU1xvwb3ob5MNKLDtogzQk4/q6ErqPUy1aSYW5CBvglc7eKB sjJW1H8mVVofOF37JIdaWSiA2FFjnWV1PJZzQFlfQxBZPZ54vTDhkYgsfBufc85lEqQ2 KqkBb5/X0YHQIoxxbzlX0C3qSbFF1QISpp7/eAntm1yKGzqw5PSkkf+9enxgS5S4qY2+ WFPh4MXOQzwhQ9holzOykLvxHB3hpJI0vRouEOglQH/X0SrkInZEvIE+ghsCc7S4cYOj tPdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vd2sj2C+/BCAJxR/LaESZDmFFOuWK440rmdqEyE8mPM=; b=TdGcjbtf7SKz3x0cEk9IhibgWfz3oQpNe6AfJ5rHDY8tjvZg13MU7srT5Cd+bJTO3a 0g/RzIWFctRRzRqzjNOcuh2hPQO7BuWCv7i6Akl/5+9DeoeDT3tmWLXq0aK59jMwtEip rUvdWl95L4IzOgr/2n+JeKJPqy97v/dGWP1uFf42Q+ti3BPVlAqH/B9rgrTqYNhg2v7B bfnF58C30c0KfyrVtGIiOFPrRlgCPKEy3jjlJ8F/UXPUJWFOHc4LtErvO5L2hlv5jacL 35CV5UYI+LPRvLcqmHEjkIMS5mYX/l9cTP2gKyLwkVjqgc/XyGB3tILHX23q0gGrtkOj T/Pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XtQOx7in; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l11si9337592edq.493.2020.07.13.07.49.50; Mon, 13 Jul 2020 07:49:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XtQOx7in; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730160AbgGMOts (ORCPT + 5 others); Mon, 13 Jul 2020 10:49:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730158AbgGMOtr (ORCPT ); Mon, 13 Jul 2020 10:49:47 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31AF8C08C5DD for ; Mon, 13 Jul 2020 07:49:47 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id f18so13445290wml.3 for ; Mon, 13 Jul 2020 07:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vd2sj2C+/BCAJxR/LaESZDmFFOuWK440rmdqEyE8mPM=; b=XtQOx7in9ZZo01xvUwtPb71cD03LuqUg5mjxFCU8fVtsM9wgJaGzymWPTCk6RAAosp ESWRw35FOp86sTVMJwxSp+XrILjPVNaKm5eCK2pxO2YBb6xZ9H+ZLaT2vHvITumQzbXA e0xswYA716id0G4VTOndgM3E07J1+apu69twfPsO9ideH7JTLI24InIpLwGzS4rOXSku iX53kFdsr7ZTu3NI1ma4fddkk7UOmVlsaKTdkRDJvVngDCOaNBReUbBp7Vl1d+PWdMPt PhJ6s5Y+oUQR9YgEpQ4OFI9JYtM+nmya6l2zMAY7SOR3HlHAA0h9rqw1J/HhR4buc3eO nfaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vd2sj2C+/BCAJxR/LaESZDmFFOuWK440rmdqEyE8mPM=; b=rBjVpdOh1ZC8nCXMJ2R9xOgM+NlLxzRSCA/cftu3Q4m/Nx3lCpxfWCeYLjwIw2a0eH rXrEFcLehLEq7T6wEzXUX8Lsr2zzJWILndlea9D5ssYgsxkLwzx71FpRUDeKK+fMAxmw t2z0inpqEvyfeEVRRXh8CF2WiPEWQUynPfz4sbiLiZFtg0zLPQ3dvUUmchYcy7pOpLP6 cVvQBhek09RhO4f6SZZfgIb7zswPKexBrHJgG28XhGptnnIa/ERvfbUQ60tvugnP22Z2 vrWh/KPx0KOohV3h5KlE2HwnJ88tnb14oXrPmD7keFS0YTYKdSUeJ434tbZcpMB9HzB6 oqug== X-Gm-Message-State: AOAM530Vc9nKHNNQ/Zy0bn1jIJe8+1z2shnJy+f0Avrwr7i89YKZI1pC fgC7sncmJU3EuNZWyerBBtgpIg== X-Received: by 2002:a05:600c:21ca:: with SMTP id x10mr288300wmj.63.1594651785916; Mon, 13 Jul 2020 07:49:45 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.6]) by smtp.gmail.com with ESMTPSA id o29sm26207756wra.5.2020.07.13.07.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 07:49:45 -0700 (PDT) From: Lee Jones To: linus.walleij@linaro.org Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Lee Jones Subject: [PATCH 12/25] pinctrl: pinmux: Add some missing parameter descriptions Date: Mon, 13 Jul 2020 15:49:17 +0100 Message-Id: <20200713144930.1034632-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200713144930.1034632-1-lee.jones@linaro.org> References: <20200713144930.1034632-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org And rename another which has probably bitrotted. Fixes the following W=1 kernel build warning(s): drivers/pinctrl/pinmux.c:83: warning: Function parameter or member 'pctldev' not described in 'pinmux_can_be_used_for_gpio' drivers/pinctrl/pinmux.c:108: warning: Function parameter or member 'pctldev' not described in 'pin_request' drivers/pinctrl/pinmux.c:261: warning: Function parameter or member 'gpio' not described in 'pinmux_request_gpio' drivers/pinctrl/pinmux.c:751: warning: Function parameter or member 'selector' not described in 'pinmux_generic_get_function' drivers/pinctrl/pinmux.c:751: warning: Excess function parameter 'group_selector' description in 'pinmux_generic_get_function' Signed-off-by: Lee Jones --- drivers/pinctrl/pinmux.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 9503ddf2edc76..bab888fe3f8e3 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -74,6 +74,7 @@ int pinmux_validate_map(const struct pinctrl_map *map, int i) * pinmux_can_be_used_for_gpio() - check if a specific pin * is either muxed to a different function or used as gpio. * + * @pctldev: the associated pin controller device * @pin: the pin number in the global pin space * * Controllers not defined as strict will always return true, @@ -96,6 +97,7 @@ bool pinmux_can_be_used_for_gpio(struct pinctrl_dev *pctldev, unsigned pin) /** * pin_request() - request a single pin to be muxed in, typically for GPIO + * @pctldev: the associated pin controller device * @pin: the pin number in the global pin space * @owner: a representation of the owner of this pin; typically the device * name that controls its mux function, or the requested GPIO name @@ -254,6 +256,7 @@ static const char *pin_free(struct pinctrl_dev *pctldev, int pin, * @pctldev: pin controller device affected * @pin: the pin to mux in for GPIO * @range: the applicable GPIO range + * @gpio: number of requested GPIO */ int pinmux_request_gpio(struct pinctrl_dev *pctldev, struct pinctrl_gpio_range *range, @@ -744,7 +747,7 @@ EXPORT_SYMBOL_GPL(pinmux_generic_get_function_groups); /** * pinmux_generic_get_function() - returns a function based on the number * @pctldev: pin controller device - * @group_selector: function number + * @selector: function number */ struct function_desc *pinmux_generic_get_function(struct pinctrl_dev *pctldev, unsigned int selector)