[18/25] pinctrl: pinctrl-bm1880: Rename ill documented struct attribute entries

Message ID 20200713144930.1034632-19-lee.jones@linaro.org
State New
Headers show
Series
  • Rid W=1 warnings in Pinctrl
Related show

Commit Message

Lee Jones July 13, 2020, 2:49 p.m.
Fixes the following W=1 kernel build warning(s):

 drivers/pinctrl/pinctrl-bm1880.c:40: warning: Function parameter or member 'pctrldev' not described in 'bm1880_pinctrl'
 drivers/pinctrl/pinctrl-bm1880.c:40: warning: Function parameter or member 'pinconf' not described in 'bm1880_pinctrl'

Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/pinctrl/pinctrl-bm1880.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1

Comments

Manivannan Sadhasivam July 14, 2020, 5:17 p.m. | #1
On Mon, Jul 13, 2020 at 03:49:23PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/pinctrl/pinctrl-bm1880.c:40: warning: Function parameter or member 'pctrldev' not described in 'bm1880_pinctrl'

>  drivers/pinctrl/pinctrl-bm1880.c:40: warning: Function parameter or member 'pinconf' not described in 'bm1880_pinctrl'

> 

> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>


Thanks,
Mani

> ---

>  drivers/pinctrl/pinctrl-bm1880.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c

> index d1a7d98367870..a8e267237435f 100644

> --- a/drivers/pinctrl/pinctrl-bm1880.c

> +++ b/drivers/pinctrl/pinctrl-bm1880.c

> @@ -22,12 +22,12 @@

>  /**

>   * struct bm1880_pinctrl - driver data

>   * @base:	Pinctrl base address

> - * @pctrl:	Pinctrl device

> + * @pctrldev:	Pinctrl device

>   * @groups:	Pingroups

>   * @ngroups:	Number of @groups

>   * @funcs:	Pinmux functions

>   * @nfuncs:	Number of @funcs

> - * @pconf:	Pinconf data

> + * @pinconf:	Pinconf data

>   */

>  struct bm1880_pinctrl {

>  	void __iomem *base;

> -- 

> 2.25.1

>

Patch

diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c
index d1a7d98367870..a8e267237435f 100644
--- a/drivers/pinctrl/pinctrl-bm1880.c
+++ b/drivers/pinctrl/pinctrl-bm1880.c
@@ -22,12 +22,12 @@ 
 /**
  * struct bm1880_pinctrl - driver data
  * @base:	Pinctrl base address
- * @pctrl:	Pinctrl device
+ * @pctrldev:	Pinctrl device
  * @groups:	Pingroups
  * @ngroups:	Number of @groups
  * @funcs:	Pinmux functions
  * @nfuncs:	Number of @funcs
- * @pconf:	Pinconf data
+ * @pinconf:	Pinconf data
  */
 struct bm1880_pinctrl {
 	void __iomem *base;