[04/25] pinctrl: bcm: pinctrl-iproc-gpio: Rename incorrectly documented function param

Message ID 20200713144930.1034632-5-lee.jones@linaro.org
State Accepted
Commit 2dd2dbc527ff9a505a020a154d309a691668abc5
Headers show
Series
  • Rid W=1 warnings in Pinctrl
Related show

Commit Message

Lee Jones July 13, 2020, 2:49 p.m.
Fixes the following W=1 kernel build warning(s):

 drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:141: warning: Function parameter or member 'chip' not described in 'iproc_set_bit'
 drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:141: warning: Excess function parameter 'iproc_gpio' description in 'iproc_set_bit'

Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.25.1

Comments

Scott Branden July 13, 2020, 5:58 p.m. | #1
thanks.

On 2020-07-13 7:49 a.m., Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

>

>   drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:141: warning: Function parameter or member 'chip' not described in 'iproc_set_bit'

>   drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:141: warning: Excess function parameter 'iproc_gpio' description in 'iproc_set_bit'

>

> Cc: Ray Jui <rjui@broadcom.com>

> Cc: Scott Branden <sbranden@broadcom.com>

> Cc: bcm-kernel-feedback-list@broadcom.com

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Acked-by: Scott Branden <scott.branden@broadcom.com>

> ---

>   drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c

> index a38f0d5f47ce9..e2bd2dce6bb41 100644

> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c

> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c

> @@ -131,7 +131,7 @@ static inline unsigned iproc_pin_to_gpio(unsigned pin)

>    *  iproc_set_bit - set or clear one bit (corresponding to the GPIO pin) in a

>    *  Iproc GPIO register

>    *

> - *  @iproc_gpio: Iproc GPIO device

> + *  @chip: Iproc GPIO device

>    *  @reg: register offset

>    *  @gpio: GPIO pin

>    *  @set: set or clear

Patch

diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index a38f0d5f47ce9..e2bd2dce6bb41 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -131,7 +131,7 @@  static inline unsigned iproc_pin_to_gpio(unsigned pin)
  *  iproc_set_bit - set or clear one bit (corresponding to the GPIO pin) in a
  *  Iproc GPIO register
  *
- *  @iproc_gpio: Iproc GPIO device
+ *  @chip: Iproc GPIO device
  *  @reg: register offset
  *  @gpio: GPIO pin
  *  @set: set or clear