diff mbox

[Xen-devel,OSSTEST] standalone: add blessing to flights table.

Message ID 1390408768-16100-1-git-send-email-ian.campbell@citrix.com
State New
Headers show

Commit Message

Ian Campbell Jan. 22, 2014, 4:39 p.m. UTC
sg-check-tested wants this to exist.

I haven't implemented Osstest/JobDB/Standalone::job_ensure_started, which
should transition from 'contructing' to 'running' because I'm not hitting that
path.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 Osstest/JobDB/Standalone.pm | 4 ++--
 standalone-reset            | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Ian Campbell March 17, 2014, 1:02 p.m. UTC | #1
ping

On Wed, 2014-01-22 at 16:39 +0000, Ian Campbell wrote:
> sg-check-tested wants this to exist.
> 
> I haven't implemented Osstest/JobDB/Standalone::job_ensure_started, which
> should transition from 'contructing' to 'running' because I'm not hitting that
> path.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
>  Osstest/JobDB/Standalone.pm | 4 ++--
>  standalone-reset            | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Osstest/JobDB/Standalone.pm b/Osstest/JobDB/Standalone.pm
> index 14293ef..45ec9ca 100644
> --- a/Osstest/JobDB/Standalone.pm
> +++ b/Osstest/JobDB/Standalone.pm
> @@ -67,8 +67,8 @@ END
>      }
>      $dbh_tests->do(<<END, {}, $fl, $branch, $intended);
>               INSERT INTO flights
> -                         (flight, branch, intended)
> -                  VALUES (?, ?, ?)
> +                         (flight, blessing, branch, intended)
> +                  VALUES (?, 'constructing', ?, ?)
>  END
>      return $fl
>  }
> diff --git a/standalone-reset b/standalone-reset
> index 8be7e86..83a6606 100755
> --- a/standalone-reset
> +++ b/standalone-reset
> @@ -131,6 +131,7 @@ else
>  	sqlite3 standalone.db <<END
>  		CREATE TABLE flights (
>  			flight TEXT PRIMARY KEY,
> +			blessing TEXT,
>  			intended TEXT,
>  			branch TEXT
>  			);
Ian Jackson March 17, 2014, 3:45 p.m. UTC | #2
Ian Campbell writes ("Re: [PATCH OSSTEST] standalone: add blessing to flights table."):
> ping
> 
> On Wed, 2014-01-22 at 16:39 +0000, Ian Campbell wrote:
> > sg-check-tested wants this to exist.
> > 
> > I haven't implemented Osstest/JobDB/Standalone::job_ensure_started, which
> > should transition from 'contructing' to 'running' because I'm not hitting that
> > path.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff mbox

Patch

diff --git a/Osstest/JobDB/Standalone.pm b/Osstest/JobDB/Standalone.pm
index 14293ef..45ec9ca 100644
--- a/Osstest/JobDB/Standalone.pm
+++ b/Osstest/JobDB/Standalone.pm
@@ -67,8 +67,8 @@  END
     }
     $dbh_tests->do(<<END, {}, $fl, $branch, $intended);
              INSERT INTO flights
-                         (flight, branch, intended)
-                  VALUES (?, ?, ?)
+                         (flight, blessing, branch, intended)
+                  VALUES (?, 'constructing', ?, ?)
 END
     return $fl
 }
diff --git a/standalone-reset b/standalone-reset
index 8be7e86..83a6606 100755
--- a/standalone-reset
+++ b/standalone-reset
@@ -131,6 +131,7 @@  else
 	sqlite3 standalone.db <<END
 		CREATE TABLE flights (
 			flight TEXT PRIMARY KEY,
+			blessing TEXT,
 			intended TEXT,
 			branch TEXT
 			);