[11/13] cpufreq: pcc-cpufreq: Remove unused ID structs

Message ID 20200714145049.2496163-12-lee.jones@linaro.org
State New
Headers show
Series
  • Rid W=1 warnings in CPUFreq
Related show

Commit Message

Lee Jones July 14, 2020, 2:50 p.m.
Can't see them being used anywhere and the compiler doesn't complain
that they're missing, so ...

Fixes the following W=1 kernel build warning(s):

 drivers/cpufreq/pcc-cpufreq.c:619:36: warning: ‘processor_device_ids’ defined but not used [-Wunused-const-variable=]
 619 | static const struct acpi_device_id processor_device_ids[] = {
 | ^~~~~~~~~~~~~~~~~~~~

Cc: Matthew Garrett <mjg@redhat.com>
Cc: Nagananda Chumbalkar <nagananda.chumbalkar@hp.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/cpufreq/pcc-cpufreq.c | 7 -------
 1 file changed, 7 deletions(-)

-- 
2.25.1

Comments

Rafael J. Wysocki July 14, 2020, 5:42 p.m. | #1
On Tue, Jul 14, 2020 at 4:51 PM Lee Jones <lee.jones@linaro.org> wrote:
>

> Can't see them being used anywhere and the compiler doesn't complain

> that they're missing, so ...


Autoloading of the module too.

> Fixes the following W=1 kernel build warning(s):

>

>  drivers/cpufreq/pcc-cpufreq.c:619:36: warning: ‘processor_device_ids’ defined but not used [-Wunused-const-variable=]

>  619 | static const struct acpi_device_id processor_device_ids[] = {

>  | ^~~~~~~~~~~~~~~~~~~~

>

> Cc: Matthew Garrett <mjg@redhat.com>

> Cc: Nagananda Chumbalkar <nagananda.chumbalkar@hp.com>

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> ---

>  drivers/cpufreq/pcc-cpufreq.c | 7 -------

>  1 file changed, 7 deletions(-)

>

> diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c

> index 5789fe7a94bd3..99cf8b78c032a 100644

> --- a/drivers/cpufreq/pcc-cpufreq.c

> +++ b/drivers/cpufreq/pcc-cpufreq.c

> @@ -616,13 +616,6 @@ static void __exit pcc_cpufreq_exit(void)

>         free_percpu(pcc_cpu_info);

>  }

>

> -static const struct acpi_device_id processor_device_ids[] = {

> -       {ACPI_PROCESSOR_OBJECT_HID, },

> -       {ACPI_PROCESSOR_DEVICE_HID, },

> -       {},

> -};

> -MODULE_DEVICE_TABLE(acpi, processor_device_ids);

> -

>  MODULE_AUTHOR("Matthew Garrett, Naga Chumbalkar");

>  MODULE_VERSION(PCC_VERSION);

>  MODULE_DESCRIPTION("Processor Clocking Control interface driver");

> --

> 2.25.1

>

Patch

diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
index 5789fe7a94bd3..99cf8b78c032a 100644
--- a/drivers/cpufreq/pcc-cpufreq.c
+++ b/drivers/cpufreq/pcc-cpufreq.c
@@ -616,13 +616,6 @@  static void __exit pcc_cpufreq_exit(void)
 	free_percpu(pcc_cpu_info);
 }
 
-static const struct acpi_device_id processor_device_ids[] = {
-	{ACPI_PROCESSOR_OBJECT_HID, },
-	{ACPI_PROCESSOR_DEVICE_HID, },
-	{},
-};
-MODULE_DEVICE_TABLE(acpi, processor_device_ids);
-
 MODULE_AUTHOR("Matthew Garrett, Naga Chumbalkar");
 MODULE_VERSION(PCC_VERSION);
 MODULE_DESCRIPTION("Processor Clocking Control interface driver");