[v2,06/13] cpufreq: powernv-cpufreq: Functions only used in call-backs should be static

Message ID 20200715082634.3024816-7-lee.jones@linaro.org
State New
Headers show
Series
  • Rid W=1 warnings in CPUFreq
Related show

Commit Message

Lee Jones July 15, 2020, 8:26 a.m.
Fixes the following W=1 kernel build warning(s):

 drivers/cpufreq/powernv-cpufreq.c:669:6: warning: no previous prototype for ‘gpstate_timer_handler’ [-Wmissing-prototypes]
 drivers/cpufreq/powernv-cpufreq.c:902:6: warning: no previous prototype for ‘powernv_cpufreq_work_fn’ [-Wmissing-prototypes]

Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

---
 drivers/cpufreq/powernv-cpufreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.25.1

Comments

Viresh Kumar July 15, 2020, 9:45 a.m. | #1
On 15-07-20, 09:26, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):

> 

>  drivers/cpufreq/powernv-cpufreq.c:669:6: warning: no previous prototype for ‘gpstate_timer_handler’ [-Wmissing-prototypes]

>  drivers/cpufreq/powernv-cpufreq.c:902:6: warning: no previous prototype for ‘powernv_cpufreq_work_fn’ [-Wmissing-prototypes]

> 

> Cc: Michael Ellerman <mpe@ellerman.id.au>

> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> Cc: Paul Mackerras <paulus@samba.org>

> Cc: linuxppc-dev@lists.ozlabs.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>

> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---

>  drivers/cpufreq/powernv-cpufreq.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c

> index 8646eb197cd96..068cc53abe320 100644

> --- a/drivers/cpufreq/powernv-cpufreq.c

> +++ b/drivers/cpufreq/powernv-cpufreq.c

> @@ -666,7 +666,7 @@ static inline void  queue_gpstate_timer(struct global_pstate_info *gpstates)

>   * according quadratic equation. Queues a new timer if it is still not equal

>   * to local pstate

>   */

> -void gpstate_timer_handler(struct timer_list *t)

> +static void gpstate_timer_handler(struct timer_list *t)

>  {

>  	struct global_pstate_info *gpstates = from_timer(gpstates, t, timer);

>  	struct cpufreq_policy *policy = gpstates->policy;

> @@ -899,7 +899,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = {

>  	.notifier_call = powernv_cpufreq_reboot_notifier,

>  };

>  

> -void powernv_cpufreq_work_fn(struct work_struct *work)

> +static void powernv_cpufreq_work_fn(struct work_struct *work)

>  {

>  	struct chip *chip = container_of(work, struct chip, throttle);

>  	struct cpufreq_policy *policy;


Don't you want to drop this patch now ? As you already reviewed the
other one on the list ?

-- 
viresh
Lee Jones July 15, 2020, 10:13 a.m. | #2
On Wed, 15 Jul 2020, Viresh Kumar wrote:

> On 15-07-20, 09:26, Lee Jones wrote:

> > Fixes the following W=1 kernel build warning(s):

> > 

> >  drivers/cpufreq/powernv-cpufreq.c:669:6: warning: no previous prototype for ‘gpstate_timer_handler’ [-Wmissing-prototypes]

> >  drivers/cpufreq/powernv-cpufreq.c:902:6: warning: no previous prototype for ‘powernv_cpufreq_work_fn’ [-Wmissing-prototypes]

> > 

> > Cc: Michael Ellerman <mpe@ellerman.id.au>

> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> > Cc: Paul Mackerras <paulus@samba.org>

> > Cc: linuxppc-dev@lists.ozlabs.org

> > Signed-off-by: Lee Jones <lee.jones@linaro.org>

> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

> > ---

> >  drivers/cpufreq/powernv-cpufreq.c | 4 ++--

> >  1 file changed, 2 insertions(+), 2 deletions(-)

> > 

> > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c

> > index 8646eb197cd96..068cc53abe320 100644

> > --- a/drivers/cpufreq/powernv-cpufreq.c

> > +++ b/drivers/cpufreq/powernv-cpufreq.c

> > @@ -666,7 +666,7 @@ static inline void  queue_gpstate_timer(struct global_pstate_info *gpstates)

> >   * according quadratic equation. Queues a new timer if it is still not equal

> >   * to local pstate

> >   */

> > -void gpstate_timer_handler(struct timer_list *t)

> > +static void gpstate_timer_handler(struct timer_list *t)

> >  {

> >  	struct global_pstate_info *gpstates = from_timer(gpstates, t, timer);

> >  	struct cpufreq_policy *policy = gpstates->policy;

> > @@ -899,7 +899,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = {

> >  	.notifier_call = powernv_cpufreq_reboot_notifier,

> >  };

> >  

> > -void powernv_cpufreq_work_fn(struct work_struct *work)

> > +static void powernv_cpufreq_work_fn(struct work_struct *work)

> >  {

> >  	struct chip *chip = container_of(work, struct chip, throttle);

> >  	struct cpufreq_policy *policy;

> 

> Don't you want to drop this patch now ? As you already reviewed the

> other one on the list ?


Yes, please drop/ignore.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
index 8646eb197cd96..068cc53abe320 100644
--- a/drivers/cpufreq/powernv-cpufreq.c
+++ b/drivers/cpufreq/powernv-cpufreq.c
@@ -666,7 +666,7 @@  static inline void  queue_gpstate_timer(struct global_pstate_info *gpstates)
  * according quadratic equation. Queues a new timer if it is still not equal
  * to local pstate
  */
-void gpstate_timer_handler(struct timer_list *t)
+static void gpstate_timer_handler(struct timer_list *t)
 {
 	struct global_pstate_info *gpstates = from_timer(gpstates, t, timer);
 	struct cpufreq_policy *policy = gpstates->policy;
@@ -899,7 +899,7 @@  static struct notifier_block powernv_cpufreq_reboot_nb = {
 	.notifier_call = powernv_cpufreq_reboot_notifier,
 };
 
-void powernv_cpufreq_work_fn(struct work_struct *work)
+static void powernv_cpufreq_work_fn(struct work_struct *work)
 {
 	struct chip *chip = container_of(work, struct chip, throttle);
 	struct cpufreq_policy *policy;