diff mbox series

[net-next,v2,2/9] net: hsr/prp: validate address B before copying to skb

Message ID 20200715164012.1222-3-m-karicheri2@ti.com
State Superseded
Headers show
Series None | expand

Commit Message

Murali Karicheri July 15, 2020, 4:40 p.m. UTC 
Validate MAC address before copying the same to outgoing frame
skb destination address.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

---
 net/hsr/hsr_framereg.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.17.1
diff mbox series

Patch

diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c
index 03b891904314..01331da28639 100644
--- a/net/hsr/hsr_framereg.c
+++ b/net/hsr/hsr_framereg.c
@@ -325,7 +325,10 @@  void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb,
 	if (port->type != node_dst->addr_B_port)
 		return;
 
-	ether_addr_copy(eth_hdr(skb)->h_dest, node_dst->macaddress_B);
+	if (is_valid_ether_addr(node_dst->macaddress_B))
+		ether_addr_copy(eth_hdr(skb)->h_dest, node_dst->macaddress_B);
+	else
+		WARN_ONCE(1, "%s: mac address B not valid\n", __func__);
 }
 
 void hsr_register_frame_in(struct hsr_node *node, struct hsr_port *port,