diff mbox series

[1/1] log: correct CONFIG_LOG_TEST prerequisites

Message ID 20200208221705.24110-1-xypron.glpk@gmx.de
State Superseded
Headers show
Series [1/1] log: correct CONFIG_LOG_TEST prerequisites | expand

Commit Message

Heinrich Schuchardt Feb. 8, 2020, 10:17 p.m. UTC
An error

	undefined reference to `do_log_test'

occurs for CONFIG_CMD_LOG=y, CONFIG_LOG_TEST=y, CONGIG_UNIT_TEST=n

Make CONFIG_UNIT_TEST a prerequisite.

Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
---
 common/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.24.1

Comments

Bin Meng Feb. 9, 2020, 2:58 a.m. UTC | #1
On Sun, Feb 9, 2020 at 6:17 AM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> An error
>
>         undefined reference to `do_log_test'
>
> occurs for CONFIG_CMD_LOG=y, CONFIG_LOG_TEST=y, CONGIG_UNIT_TEST=n
>
> Make CONFIG_UNIT_TEST a prerequisite.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  common/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
Simon Glass Feb. 11, 2020, 11:03 p.m. UTC | #2
On Sat, 8 Feb 2020 at 15:17, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> An error
>
>         undefined reference to `do_log_test'
>
> occurs for CONFIG_CMD_LOG=y, CONFIG_LOG_TEST=y, CONGIG_UNIT_TEST=n
>
> Make CONFIG_UNIT_TEST a prerequisite.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  common/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg at chromium.org>
diff mbox series

Patch

diff --git a/common/Kconfig b/common/Kconfig
index 16a67f5f76..5ad23ce2c4 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -782,7 +782,7 @@  config LOG_SYSLOG

 config LOG_TEST
 	bool "Provide a test for logging"
-	depends on LOG
+	depends on LOG && UNIT_TEST
 	default y if SANDBOX
 	help
 	  This enables a 'log test' command to test logging. It is normally