diff mbox series

mmc: make <mmc.h> self-contained

Message ID 20200224172530.13949-1-masahiroy@kernel.org
State Accepted
Commit bd602c536771c53d0d56273d8f7d6596425b8f5c
Headers show
Series mmc: make <mmc.h> self-contained | expand

Commit Message

Masahiro Yamada Feb. 24, 2020, 5:25 p.m. UTC
This header uses bd_t without including its definition.

Change it to (struct bd_info), and add the forward declaration
to specify it as a structure.

Signed-off-by: Masahiro Yamada <masahiroy at kernel.org>
---

 include/mmc.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Jaehoon Chung Feb. 25, 2020, 10:09 p.m. UTC | #1
On 2/25/20 2:25 AM, Masahiro Yamada wrote:
> This header uses bd_t without including its definition.
> 
> Change it to (struct bd_info), and add the forward declaration
> to specify it as a structure.
> 
> Signed-off-by: Masahiro Yamada <masahiroy at kernel.org>

Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Best Regards,
Jaehoon Chung

> ---
> 
>  include/mmc.h | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/include/mmc.h b/include/mmc.h
> index 71e2e1735a..4bdeb929d7 100644
> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -15,6 +15,8 @@
>  #include <linux/dma-direction.h>
>  #include <part.h>
>  
> +struct bd_info;
> +
>  #if CONFIG_IS_ENABLED(MMC_HS200_SUPPORT)
>  #define MMC_SUPPORTS_TUNING
>  #endif
> @@ -712,7 +714,7 @@ void mmc_destroy(struct mmc *mmc);
>   * @return 0 if OK, -ve on error
>   */
>  int mmc_unbind(struct udevice *dev);
> -int mmc_initialize(bd_t *bis);
> +int mmc_initialize(struct bd_info *bis);
>  int mmc_init_device(int num);
>  int mmc_init(struct mmc *mmc);
>  int mmc_send_tuning(struct mmc *mmc, u32 opcode, int *cmd_error);
> @@ -857,8 +859,8 @@ void mmc_set_preinit(struct mmc *mmc, int preinit);
>  #endif
>  
>  void board_mmc_power_init(void);
> -int board_mmc_init(bd_t *bis);
> -int cpu_mmc_init(bd_t *bis);
> +int board_mmc_init(struct bd_info *bis);
> +int cpu_mmc_init(struct bd_info *bis);
>  int mmc_get_env_addr(struct mmc *mmc, int copy, u32 *env_addr);
>  # ifdef CONFIG_SYS_MMC_ENV_PART
>  extern uint mmc_get_env_part(struct mmc *mmc);
>
Tom Rini March 17, 2020, 3:28 p.m. UTC | #2
On Tue, Feb 25, 2020 at 02:25:30AM +0900, Masahiro Yamada wrote:

> This header uses bd_t without including its definition.
> 
> Change it to (struct bd_info), and add the forward declaration
> to specify it as a structure.
> 
> Signed-off-by: Masahiro Yamada <masahiroy at kernel.org>
> Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/include/mmc.h b/include/mmc.h
index 71e2e1735a..4bdeb929d7 100644
--- a/include/mmc.h
+++ b/include/mmc.h
@@ -15,6 +15,8 @@ 
 #include <linux/dma-direction.h>
 #include <part.h>
 
+struct bd_info;
+
 #if CONFIG_IS_ENABLED(MMC_HS200_SUPPORT)
 #define MMC_SUPPORTS_TUNING
 #endif
@@ -712,7 +714,7 @@  void mmc_destroy(struct mmc *mmc);
  * @return 0 if OK, -ve on error
  */
 int mmc_unbind(struct udevice *dev);
-int mmc_initialize(bd_t *bis);
+int mmc_initialize(struct bd_info *bis);
 int mmc_init_device(int num);
 int mmc_init(struct mmc *mmc);
 int mmc_send_tuning(struct mmc *mmc, u32 opcode, int *cmd_error);
@@ -857,8 +859,8 @@  void mmc_set_preinit(struct mmc *mmc, int preinit);
 #endif
 
 void board_mmc_power_init(void);
-int board_mmc_init(bd_t *bis);
-int cpu_mmc_init(bd_t *bis);
+int board_mmc_init(struct bd_info *bis);
+int cpu_mmc_init(struct bd_info *bis);
 int mmc_get_env_addr(struct mmc *mmc, int copy, u32 *env_addr);
 # ifdef CONFIG_SYS_MMC_ENV_PART
 extern uint mmc_get_env_part(struct mmc *mmc);