diff mbox series

[4/4] imx: pmic: Set proper pmic name for iMX53 HSC|DDC boards

Message ID 20200226113703.10526-5-lukma@denx.de
State Accepted
Commit 7c0fbf2fe3f87193691828d94cadb0a62b4e9f5f
Headers show
Series imx: Fixes for i.MX53 based HSC|DDC boards | expand

Commit Message

Lukasz Majewski Feb. 26, 2020, 11:37 a.m. UTC
After the
commit 4213609cc7fb ("drivers: core: use strcmp when find device by name")
the exact DTS node name for PMIC device must be provided.

This patch fixes this issue by providing full DTS node name ('mc34708 at 8').

Signed-off-by: Lukasz Majewski <lukma at denx.de>
---

 board/k+p/kp_imx53/kp_imx53.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jaehoon Chung Feb. 26, 2020, 11:37 p.m. UTC | #1
On 2/26/20 8:37 PM, Lukasz Majewski wrote:
> After the
> commit 4213609cc7fb ("drivers: core: use strcmp when find device by name")
> the exact DTS node name for PMIC device must be provided.
> 
> This patch fixes this issue by providing full DTS node name ('mc34708 at 8').
> 
> Signed-off-by: Lukasz Majewski <lukma at denx.de>

Reviewed-by: Jaehoon Chug <jh80.chung at samsung.com>

> ---
> 
>  board/k+p/kp_imx53/kp_imx53.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/k+p/kp_imx53/kp_imx53.c b/board/k+p/kp_imx53/kp_imx53.c
> index 2f57310e27..eb5b67d1e6 100644
> --- a/board/k+p/kp_imx53/kp_imx53.c
> +++ b/board/k+p/kp_imx53/kp_imx53.c
> @@ -48,7 +48,7 @@ static int power_init(void)
>  	struct udevice *dev;
>  	int ret;
>  
> -	ret = pmic_get("mc34708", &dev);
> +	ret = pmic_get("mc34708 at 8", &dev);
>  	if (ret) {
>  		printf("%s: mc34708 not found !\n", __func__);
>  		return ret;
>
Stefano Babic April 19, 2020, 9:08 a.m. UTC | #2
> After the
> commit 4213609cc7fb ("drivers: core: use strcmp when find device by name")
> the exact DTS node name for PMIC device must be provided.
> This patch fixes this issue by providing full DTS node name ('mc34708 at 8').
> Signed-off-by: Lukasz Majewski <lukma at denx.de>
> Reviewed-by: Jaehoon Chug <jh80.chung at samsung.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/k+p/kp_imx53/kp_imx53.c b/board/k+p/kp_imx53/kp_imx53.c
index 2f57310e27..eb5b67d1e6 100644
--- a/board/k+p/kp_imx53/kp_imx53.c
+++ b/board/k+p/kp_imx53/kp_imx53.c
@@ -48,7 +48,7 @@  static int power_init(void)
 	struct udevice *dev;
 	int ret;
 
-	ret = pmic_get("mc34708", &dev);
+	ret = pmic_get("mc34708 at 8", &dev);
 	if (ret) {
 		printf("%s: mc34708 not found !\n", __func__);
 		return ret;