diff mbox series

[14/22] buildman: Show a message when fetching a repo

Message ID	20200405092116.14.Id46378e9383a2e8760b31d9345fe6a6bab0cb4bc@changeid
State	Superseded
Headers	show List-Id: U-Boot discussion <u-boot.lists.denx.de> From: sjg at chromium.org (Simon Glass) Date: Sun, 5 Apr 2020 09:21:23 -0600 Subject: [PATCH 14/22] buildman: Show a message when fetching a repo In-Reply-To: <20200405152131.98147-1-sjg@chromium.org> References: <20200405152131.98147-1-sjg@chromium.org> Message-ID: <20200405092116.14.Id46378e9383a2e8760b31d9345fe6a6bab0cb4bc@changeid>
Series	buildman: Improve summary output \| expand [00/22] buildman: Improve summary output [01/22] buildman: Refactor error-line output int a function [02/22] buildman: Add test coverage for error/warning colour [03/22] buildman: Use an iterator to check test output [04/22] buildman: Create temp directory in test setup [05/22] buildman: Split out testOutput() into separate functions [06/22] buildman: Add a test helper for creating a line prefix [07/22] buildman: Test the output with --list-error-boards [08/22] buildman: Use yellow consistently for warning lines [09/22] buildman: Use an object to hold error lines [10/22] buildman: Show the list of boards in magenta [11/22] patman: Update flushing Print() for Python 3 [12/22] patman: Support erasing a previously unfinished text line [13/22] buildman: Drop the line-clearing code in Builder [14/22] buildman: Show a message when fetching a repo [15/22] buildman: Drop unused output code [16/22] buildman: Show the number of builds remaining [17/22] buildman: Show a summary of the build result [18/22] buildman: Update the 'theory of operation' a little [19/22] buildman: Add the abbreviation for --boards [20/22] buildman: Update workflow documentation with more detail [21/22] buildman: Make -I the default [22/22] buildman: Add an option to ignore device-tree warnings

Commit Message

Simon Glass April 5, 2020, 3:21 p.m. UTC

Fetching updated versions of a repo can take time. At present buildman
gives no indication that it is doing this.

Add a message to explain the delay.

Tidy up a few other messages while we are here.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 tools/buildman/builder.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py
index 7901c92ef32..48bbc0aeeca 100644
--- a/tools/buildman/builder.py
+++ b/tools/buildman/builder.py
@@ -1533,7 +1533,10 @@  class Builder:
         if setup_git and self.git_dir:
             src_dir = os.path.abspath(self.git_dir)
             if os.path.exists(git_dir):
+                Print('\rFetching repo for thread %d' % thread_num,
+                      newline=False)
                 gitutil.Fetch(git_dir, thread_dir)
+                terminal.PrintClear()
             else:
                 Print('\rCloning repo for thread %d' % thread_num,
                       newline=False)
@@ -1591,7 +1594,7 @@  class Builder:
                   newline=False)
             for dirname in to_remove:
                 shutil.rmtree(dirname)
-            Print('done')
+            terminal.PrintClear()
 
     def BuildBoards(self, commits, board_selected, keep_outputs, verbose):
         """Build all commits for a list of boards