diff mbox series

[v7,16/17] travis: add packages for UEFI secure boot test

Message ID 20200414025154.27283-17-takahiro.akashi@linaro.org
State Superseded
Headers show
Series efi_loader: add secure boot support | expand

Commit Message

AKASHI Takahiro April 14, 2020, 2:51 a.m. UTC
Pytest for UEFI secure boot will use several host commands.
In particular, Test setup relies on efitools, whose version must be v1.5.2
or later. So fetch a new version of deb package directly.
Please note it has a dependency on mtools, which must also be installed
along wih efitools.

In addition, the path, '/sbin', is added to PATH for use of sgdisk and
mkfs.

Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
Reviewed-by: Tom Rini <trini at konsulko.com>
---
 .travis.yml | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Heinrich Schuchardt April 14, 2020, 3:33 p.m. UTC | #1
On 2020-04-14 04:51, AKASHI Takahiro wrote:
> Pytest for UEFI secure boot will use several host commands.
> In particular, Test setup relies on efitools, whose version must be v1.5.2
> or later. So fetch a new version of deb package directly.
> Please note it has a dependency on mtools, which must also be installed
> along wih efitools.
>
> In addition, the path, '/sbin', is added to PATH for use of sgdisk and
> mkfs.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> Reviewed-by: Tom Rini <trini at konsulko.com>
> ---
>  .travis.yml | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index c59bd7790b66..b08dd030ef02 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -40,6 +40,14 @@ addons:
>      - clang-7
>      - srecord
>      - graphviz
> +    - coreutils
> +    - util-linux
> +    - dosfstools
> +    - gdisk
> +    - mount
> +    - mtools
> +    - openssl
> +    - sbsigntool
>
>  install:
>   # Clone uboot-test-hooks
> @@ -60,10 +68,11 @@ install:
>   - mkdir ~/grub2-arm64
>   - ( cd ~/grub2-arm64; wget -O - http://download.opensuse.org/ports/aarch64/distribution/leap/42.2/repo/oss/suse/aarch64/grub2-arm64-efi-2.02~beta2-87.1.aarch64.rpm | rpm2cpio | cpio -di )
>   - wget http://mirrors.kernel.org/ubuntu/pool/main/m/mpfr4/libmpfr4_3.1.4-1_amd64.deb && sudo dpkg -i libmpfr4_3.1.4-1_amd64.deb && rm libmpfr4_3.1.4-1_amd64.deb
> + - wget http://mirrors.kernel.org/ubuntu/pool/universe/e/efitools/efitools_1.8.1-0ubuntu2_amd64.deb && sudo dpkg -i efitools_1.8.1-0ubuntu2_amd64.deb && rm efitools_1.8.1-0ubuntu2_amd64.deb

Don't we need changes in the Gitlab CI and Azure CI configurations as well?

Best regards

Heinrich

>
>  env:
>    global:
> -    - PATH=/tmp/qemu-install/bin:/tmp/uboot-test-hooks/bin:/usr/bin:/bin:/usr/local/bin
> +    - PATH=/tmp/qemu-install/bin:/tmp/uboot-test-hooks/bin:/sbin:/usr/bin:/bin:/usr/local/bin
>      - PYTHONPATH=/tmp/uboot-test-hooks/py/travis-ci
>      - BUILD_DIR=build
>      - HOSTCC="cc"
>
AKASHI Takahiro April 15, 2020, 12:22 a.m. UTC | #2
Heinrich,

On Tue, Apr 14, 2020 at 05:33:18PM +0200, Heinrich Schuchardt wrote:
> On 2020-04-14 04:51, AKASHI Takahiro wrote:
> > Pytest for UEFI secure boot will use several host commands.
> > In particular, Test setup relies on efitools, whose version must be v1.5.2
> > or later. So fetch a new version of deb package directly.
> > Please note it has a dependency on mtools, which must also be installed
> > along wih efitools.
> >
> > In addition, the path, '/sbin', is added to PATH for use of sgdisk and
> > mkfs.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> > Reviewed-by: Tom Rini <trini at konsulko.com>
> > ---
> >  .travis.yml | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index c59bd7790b66..b08dd030ef02 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -40,6 +40,14 @@ addons:
> >      - clang-7
> >      - srecord
> >      - graphviz
> > +    - coreutils
> > +    - util-linux
> > +    - dosfstools
> > +    - gdisk
> > +    - mount
> > +    - mtools
> > +    - openssl
> > +    - sbsigntool
> >
> >  install:
> >   # Clone uboot-test-hooks
> > @@ -60,10 +68,11 @@ install:
> >   - mkdir ~/grub2-arm64
> >   - ( cd ~/grub2-arm64; wget -O - http://download.opensuse.org/ports/aarch64/distribution/leap/42.2/repo/oss/suse/aarch64/grub2-arm64-efi-2.02~beta2-87.1.aarch64.rpm | rpm2cpio | cpio -di )
> >   - wget http://mirrors.kernel.org/ubuntu/pool/main/m/mpfr4/libmpfr4_3.1.4-1_amd64.deb && sudo dpkg -i libmpfr4_3.1.4-1_amd64.deb && rm libmpfr4_3.1.4-1_amd64.deb
> > + - wget http://mirrors.kernel.org/ubuntu/pool/universe/e/efitools/efitools_1.8.1-0ubuntu2_amd64.deb && sudo dpkg -i efitools_1.8.1-0ubuntu2_amd64.deb && rm efitools_1.8.1-0ubuntu2_amd64.deb
> 
> Don't we need changes in the Gitlab CI and Azure CI configurations as well?

I think that this is a repeated question.
Please see Tom's reply in [1].

[1] https://lists.denx.de/pipermail/u-boot/2020-February/401424.html

Thanks,
-Takahiro Akashi

> 
> Best regards
> 
> Heinrich
> 
> >
> >  env:
> >    global:
> > -    - PATH=/tmp/qemu-install/bin:/tmp/uboot-test-hooks/bin:/usr/bin:/bin:/usr/local/bin
> > +    - PATH=/tmp/qemu-install/bin:/tmp/uboot-test-hooks/bin:/sbin:/usr/bin:/bin:/usr/local/bin
> >      - PYTHONPATH=/tmp/uboot-test-hooks/py/travis-ci
> >      - BUILD_DIR=build
> >      - HOSTCC="cc"
> >
>
diff mbox series

Patch

diff --git a/.travis.yml b/.travis.yml
index c59bd7790b66..b08dd030ef02 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -40,6 +40,14 @@  addons:
     - clang-7
     - srecord
     - graphviz
+    - coreutils
+    - util-linux
+    - dosfstools
+    - gdisk
+    - mount
+    - mtools
+    - openssl
+    - sbsigntool
 
 install:
  # Clone uboot-test-hooks
@@ -60,10 +68,11 @@  install:
  - mkdir ~/grub2-arm64
  - ( cd ~/grub2-arm64; wget -O - http://download.opensuse.org/ports/aarch64/distribution/leap/42.2/repo/oss/suse/aarch64/grub2-arm64-efi-2.02~beta2-87.1.aarch64.rpm | rpm2cpio | cpio -di )
  - wget http://mirrors.kernel.org/ubuntu/pool/main/m/mpfr4/libmpfr4_3.1.4-1_amd64.deb && sudo dpkg -i libmpfr4_3.1.4-1_amd64.deb && rm libmpfr4_3.1.4-1_amd64.deb
+ - wget http://mirrors.kernel.org/ubuntu/pool/universe/e/efitools/efitools_1.8.1-0ubuntu2_amd64.deb && sudo dpkg -i efitools_1.8.1-0ubuntu2_amd64.deb && rm efitools_1.8.1-0ubuntu2_amd64.deb
 
 env:
   global:
-    - PATH=/tmp/qemu-install/bin:/tmp/uboot-test-hooks/bin:/usr/bin:/bin:/usr/local/bin
+    - PATH=/tmp/qemu-install/bin:/tmp/uboot-test-hooks/bin:/sbin:/usr/bin:/bin:/usr/local/bin
     - PYTHONPATH=/tmp/uboot-test-hooks/py/travis-ci
     - BUILD_DIR=build
     - HOSTCC="cc"