| Message ID | 20200420084624.110026-8-ley.foon.tan@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | ddr: altera: arria10: Convert SDRAM driver to DM | expand |
On Mon, Apr 20, 2020 at 4:46 PM Ley Foon Tan <ley.foon.tan at intel.com> wrote: > > dram_init_banksize() is called in board_init_f() boot sequences > in Uboot, remove it from SDRAM driver. > > Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com> > --- > drivers/ddr/altera/sdram_arria10.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/ddr/altera/sdram_arria10.c b/drivers/ddr/altera/sdram_arria10.c > index e4944ef95183..27fd393e6fe4 100644 > --- a/drivers/ddr/altera/sdram_arria10.c > +++ b/drivers/ddr/altera/sdram_arria10.c > @@ -660,9 +660,6 @@ static int ddr_calibration_sequence(struct altera_sdram_platdata *plat) > else > gd->ram_size = (u32)size; > > - /* setup the dram info within bd */ > - dram_init_banksize(); > - > if (of_sdram_firewall_setup(gd->fdt_blob)) > puts("FW: Error Configuring Firewall\n"); > Hi Need to drop this patch, Found that dcache_enable() needs gd->bd->bi_dram[]. I will send v3. Thanks. Regards Ley Foon
On 4/30/20 1:02 PM, Ley Foon Tan wrote: > On Mon, Apr 20, 2020 at 4:46 PM Ley Foon Tan <ley.foon.tan at intel.com> wrote: >> >> dram_init_banksize() is called in board_init_f() boot sequences >> in Uboot, remove it from SDRAM driver. >> >> Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com> >> --- >> drivers/ddr/altera/sdram_arria10.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/ddr/altera/sdram_arria10.c b/drivers/ddr/altera/sdram_arria10.c >> index e4944ef95183..27fd393e6fe4 100644 >> --- a/drivers/ddr/altera/sdram_arria10.c >> +++ b/drivers/ddr/altera/sdram_arria10.c >> @@ -660,9 +660,6 @@ static int ddr_calibration_sequence(struct altera_sdram_platdata *plat) >> else >> gd->ram_size = (u32)size; >> >> - /* setup the dram info within bd */ >> - dram_init_banksize(); >> - >> if (of_sdram_firewall_setup(gd->fdt_blob)) >> puts("FW: Error Configuring Firewall\n"); >> > Hi > > Need to drop this patch, Found that dcache_enable() needs gd->bd->bi_dram[]. > I will send v3. OK, thanks.
diff --git a/drivers/ddr/altera/sdram_arria10.c b/drivers/ddr/altera/sdram_arria10.c index e4944ef95183..27fd393e6fe4 100644 --- a/drivers/ddr/altera/sdram_arria10.c +++ b/drivers/ddr/altera/sdram_arria10.c @@ -660,9 +660,6 @@ static int ddr_calibration_sequence(struct altera_sdram_platdata *plat) else gd->ram_size = (u32)size; - /* setup the dram info within bd */ - dram_init_banksize(); - if (of_sdram_firewall_setup(gd->fdt_blob)) puts("FW: Error Configuring Firewall\n");
dram_init_banksize() is called in board_init_f() boot sequences in Uboot, remove it from SDRAM driver. Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com> --- drivers/ddr/altera/sdram_arria10.c | 3 --- 1 file changed, 3 deletions(-)