diff mbox series

[5/8] configs: slimbootloader: Add x86_64 slimbootloader config

Message ID 20200422004507.2025-6-aiden.park@intel.com
State New
Headers show
Series Support 64-bit U-Boot for Slim Bootloader | expand

Commit Message

Park, Aiden April 22, 2020, 12:45 a.m. UTC
From: Aiden Park <aiden.park at intel.com>

Add slimbootloader-x86_64_defconfig for 64-bit slimbootloader board.

Signed-off-by: Aiden Park <aiden.park at intel.com>
---
 configs/slimbootloader-x86_64_defconfig | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 configs/slimbootloader-x86_64_defconfig

Comments

Simon Glass April 26, 2020, 8:32 p.m. UTC | #1
Hi Aiden,

On Tue, 21 Apr 2020 at 18:45, <aiden.park at intel.com> wrote:
>
> From: Aiden Park <aiden.park at intel.com>
>
> Add slimbootloader-x86_64_defconfig for 64-bit slimbootloader board.
>
> Signed-off-by: Aiden Park <aiden.park at intel.com>
> ---
>  configs/slimbootloader-x86_64_defconfig | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 configs/slimbootloader-x86_64_defconfig

How about slimbootloader64?

We always know it is x86.

Regards,
Simon
Park, Aiden April 29, 2020, 6:02 a.m. UTC | #2
Hi Simon,

> -----Original Message-----
> From: Simon Glass <sjg at chromium.org>
> Sent: Sunday, April 26, 2020 1:32 PM
> To: Park, Aiden <aiden.park at intel.com>
> Cc: Bin Meng <bmeng.cn at gmail.com>; U-Boot Mailing List <u-
> boot at lists.denx.de>
> Subject: Re: [PATCH 5/8] configs: slimbootloader: Add x86_64 slimbootloader
> config
> 
> Hi Aiden,
> 
> On Tue, 21 Apr 2020 at 18:45, <aiden.park at intel.com> wrote:
> >
> > From: Aiden Park <aiden.park at intel.com>
> >
> > Add slimbootloader-x86_64_defconfig for 64-bit slimbootloader board.
> >
> > Signed-off-by: Aiden Park <aiden.park at intel.com>
> > ---
> >  configs/slimbootloader-x86_64_defconfig | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 configs/slimbootloader-x86_64_defconfig
> 
> How about slimbootloader64?
> 
> We always know it is x86.
> 
Thanks for your suggestion. I will rename it to slimbootloader64.

> Regards,
> Simon

Best Regards,
Aiden
Bin Meng April 30, 2020, 9:13 a.m. UTC | #3
On Mon, Apr 27, 2020 at 4:32 AM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Aiden,
>
> On Tue, 21 Apr 2020 at 18:45, <aiden.park at intel.com> wrote:
> >
> > From: Aiden Park <aiden.park at intel.com>
> >
> > Add slimbootloader-x86_64_defconfig for 64-bit slimbootloader board.
> >
> > Signed-off-by: Aiden Park <aiden.park at intel.com>
> > ---
> >  configs/slimbootloader-x86_64_defconfig | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 configs/slimbootloader-x86_64_defconfig
>
> How about slimbootloader64?
>
> We always know it is x86.

Agreed with Simon,

Aiden, please also make sure the defconfig file is written with all
options in the correct order. You can do it like this:

$ make slimbootloader64_defconfig
$ make savedefconfig
$ cp defconfig configs/slimbootloader64_defconfig

Regards,
Bin
diff mbox series

Patch

diff --git a/configs/slimbootloader-x86_64_defconfig b/configs/slimbootloader-x86_64_defconfig
new file mode 100644
index 0000000000..f046c30179
--- /dev/null
+++ b/configs/slimbootloader-x86_64_defconfig
@@ -0,0 +1,24 @@ 
+CONFIG_X86=y
+CONFIG_X86_RUN_64BIT_ONLY=y
+CONFIG_ENV_SIZE=0x1000
+CONFIG_VENDOR_INTEL=y
+CONFIG_TARGET_SLIMBOOTLOADER=y
+# CONFIG_USE_CAR is not set
+CONFIG_BOOTSTAGE=y
+CONFIG_BOOTSTAGE_REPORT=y
+CONFIG_BOOTDELAY=10
+CONFIG_SYS_CONSOLE_INFO_QUIET=y
+CONFIG_BOARD_EARLY_INIT_R=y
+CONFIG_LAST_STAGE_INIT=y
+CONFIG_HUSH_PARSER=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_FAT=y
+CONFIG_EFI_PARTITION=y
+CONFIG_DEFAULT_DEVICE_TREE="slimbootloader"
+CONFIG_SYS_RELOC_GD_ENV_ADDR=y
+CONFIG_REGMAP=y
+CONFIG_SYSCON=y
+# CONFIG_PCI_PNP is not set
+CONFIG_CONSOLE_SCROLL_LINES=5