diff mbox series

[v3,6/9] rockchip: rk3328: Disable generic PHY support

Message ID 20200427065254.15397-7-wens@kernel.org
State New
Headers show
Series rockchip: rk3328: sync dts and add ROC-RK3328-CC board | expand

Commit Message

Chen-Yu Tsai April 27, 2020, 6:52 a.m. UTC 
From: Chen-Yu Tsai <wens at csie.org>

The USB PHYs on the RK3328 aren't supported, nor are any other generic
PHYs. Because upstream Linux device trees already include the USB PHYs
and references in the USB hosts, this would result in various calls
to the generic PHY API to fail.

Instead, just disable generic PHY support for now.

Signed-off-by: Chen-Yu Tsai <wens at csie.org>
---
Changes since v2:
  - New patch
---
 configs/evb-rk3328_defconfig    | 1 -
 configs/rock64-rk3328_defconfig | 1 -
 2 files changed, 2 deletions(-)

Comments

Kever Yang April 28, 2020, 2:24 p.m. UTC | #1 
On 2020/4/27 ??2:52, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens at csie.org>
>
> The USB PHYs on the RK3328 aren't supported, nor are any other generic
> PHYs. Because upstream Linux device trees already include the USB PHYs
> and references in the USB hosts, this would result in various calls
> to the generic PHY API to fail.
>
> Instead, just disable generic PHY support for now.
>
> Signed-off-by: Chen-Yu Tsai <wens at csie.org>

Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
> Changes since v2:
>    - New patch
> ---
>   configs/evb-rk3328_defconfig    | 1 -
>   configs/rock64-rk3328_defconfig | 1 -
>   2 files changed, 2 deletions(-)
>
> diff --git a/configs/evb-rk3328_defconfig b/configs/evb-rk3328_defconfig
> index 5bbdc002148c..7667bb037b3d 100644
> --- a/configs/evb-rk3328_defconfig
> +++ b/configs/evb-rk3328_defconfig
> @@ -61,7 +61,6 @@ CONFIG_SF_DEFAULT_SPEED=20000000
>   CONFIG_DM_ETH=y
>   CONFIG_ETH_DESIGNWARE=y
>   CONFIG_GMAC_ROCKCHIP=y
> -CONFIG_PHY=y
>   CONFIG_PINCTRL=y
>   CONFIG_SPL_PINCTRL=y
>   CONFIG_DM_PMIC=y
> diff --git a/configs/rock64-rk3328_defconfig b/configs/rock64-rk3328_defconfig
> index 826c7a691742..7d096d38c6d0 100644
> --- a/configs/rock64-rk3328_defconfig
> +++ b/configs/rock64-rk3328_defconfig
> @@ -60,7 +60,6 @@ CONFIG_SF_DEFAULT_SPEED=20000000
>   CONFIG_DM_ETH=y
>   CONFIG_ETH_DESIGNWARE=y
>   CONFIG_GMAC_ROCKCHIP=y
> -CONFIG_PHY=y
>   CONFIG_PINCTRL=y
>   CONFIG_SPL_PINCTRL=y
>   CONFIG_DM_PMIC=y
diff mbox series

Patch

diff --git a/configs/evb-rk3328_defconfig b/configs/evb-rk3328_defconfig
index 5bbdc002148c..7667bb037b3d 100644
--- a/configs/evb-rk3328_defconfig
+++ b/configs/evb-rk3328_defconfig
@@ -61,7 +61,6 @@  CONFIG_SF_DEFAULT_SPEED=20000000
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
-CONFIG_PHY=y
 CONFIG_PINCTRL=y
 CONFIG_SPL_PINCTRL=y
 CONFIG_DM_PMIC=y
diff --git a/configs/rock64-rk3328_defconfig b/configs/rock64-rk3328_defconfig
index 826c7a691742..7d096d38c6d0 100644
--- a/configs/rock64-rk3328_defconfig
+++ b/configs/rock64-rk3328_defconfig
@@ -60,7 +60,6 @@  CONFIG_SF_DEFAULT_SPEED=20000000
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_GMAC_ROCKCHIP=y
-CONFIG_PHY=y
 CONFIG_PINCTRL=y
 CONFIG_SPL_PINCTRL=y
 CONFIG_DM_PMIC=y