| Message ID | 20200110002839.97868-1-marex@denx.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/5] ARM: stm32: Permit multiple board targets | expand |
Hi Marek, > From: Marek Vasut <marex at denx.de> > Sent: vendredi 10 janvier 2020 01:29 > > Setting TARGET_STM32MP1 in Kconfig always forces SYS_BOARD, > SYS_VENDOR and SYS_CONFIG_NAME to values set by the ST reference > platforms. Allow changing that by pulling out the TARGET_STM32MP157C_DK2 > and making the ST reference platform settings conditional on > TARGET_STM32MP157C_DK2 . > Other platforms can now define a different TARGET_ and thus override the SYS_ > settings in their Kconfig. Reviewed-by: Patrick Delaunay <patrick.delaunay at st.com> It seens my configuration between SOC (STM32MP15x) and BOARD is not clean... So I prepare a patchset to change it. But I will apply it after your serie... to avoid regression on your board Regards Patrick > Signed-off-by: Marek Vasut <marex at denx.de> > Cc: Patrick Delaunay <patrick.delaunay at st.com> > Cc: Patrice Chotard <patrice.chotard at st.com> > ---
On 1/13/20 11:58 AM, Patrick DELAUNAY wrote: > Hi Marek, > >> From: Marek Vasut <marex at denx.de> >> Sent: vendredi 10 janvier 2020 01:29 >> >> Setting TARGET_STM32MP1 in Kconfig always forces SYS_BOARD, >> SYS_VENDOR and SYS_CONFIG_NAME to values set by the ST reference >> platforms. Allow changing that by pulling out the TARGET_STM32MP157C_DK2 >> and making the ST reference platform settings conditional on >> TARGET_STM32MP157C_DK2 . >> Other platforms can now define a different TARGET_ and thus override the SYS_ >> settings in their Kconfig. > > Reviewed-by: Patrick Delaunay <patrick.delaunay at st.com> > > It seens my configuration between SOC (STM32MP15x) and BOARD is not clean... > > So I prepare a patchset to change it. > But I will apply it after your serie... > to avoid regression on your board > > Regards Patrick Can you apply whatever you feel applicable from the series I posted and push it to some git repo, so I don't have to reset all things over and over again ?
Hi Marek, > From: Marek Vasut <marex at denx.de> > Sent: lundi 13 janvier 2020 12:08 > > On 1/13/20 11:58 AM, Patrick DELAUNAY wrote: > > Hi Marek, > > > >> From: Marek Vasut <marex at denx.de> > >> Sent: vendredi 10 janvier 2020 01:29 > >> > >> Setting TARGET_STM32MP1 in Kconfig always forces SYS_BOARD, > >> SYS_VENDOR and SYS_CONFIG_NAME to values set by the ST reference > >> platforms. Allow changing that by pulling out the > >> TARGET_STM32MP157C_DK2 and making the ST reference platform settings > >> conditional on > >> TARGET_STM32MP157C_DK2 . > >> Other platforms can now define a different TARGET_ and thus override > >> the SYS_ settings in their Kconfig. > > > > Reviewed-by: Patrick Delaunay <patrick.delaunay at st.com> > > > > It seens my configuration between SOC (STM32MP15x) and BOARD is not > clean... > > > > So I prepare a patchset to change it. > > But I will apply it after your serie... > > to avoid regression on your board > > > > Regards Patrick > > Can you apply whatever you feel applicable from the series I posted and push it to > some git repo, so I don't have to reset all things over and over again ? Sure. https://gitlab.denx.de/u-boot/custodians/u-boot-stm.git => branch master : the paches accepted [V3] stm32mp1: configs: Make all boot devices in distro boot conditional [2/5] ARM: stm32: Allow overriding setup_mac_address() They will be included in my next pull request => branch next + my serie = http://patchwork.ozlabs.org/project/uboot/list/?series=152828 + your serie (including my proposals of update) http://patchwork.ozlabs.org/project/uboot/list/?series=152293 [3/5] ARM: stm32: Fill in missing loadaddr => I change address to 0xc2000000 [5/5] ARM: dts: stm32: Add DH Electronics DHCOM SoM and PDK2 board I make a lot of modification after my serie and my review.... Can you check the delta and tell me if it is working... NB: no more needed after my serie => [1/5] ARM: stm32: Permit multiple board targets i PS: [4/5] ARM: dts: stm32: Add missing ETHCK clock to ethernet node I ma waiting Christophe / kernel feedback.... Patrick
On 1/13/20 4:07 PM, Patrick DELAUNAY wrote: > Hi Marek, > >> From: Marek Vasut <marex at denx.de> >> Sent: lundi 13 janvier 2020 12:08 >> >> On 1/13/20 11:58 AM, Patrick DELAUNAY wrote: >>> Hi Marek, >>> >>>> From: Marek Vasut <marex at denx.de> >>>> Sent: vendredi 10 janvier 2020 01:29 >>>> >>>> Setting TARGET_STM32MP1 in Kconfig always forces SYS_BOARD, >>>> SYS_VENDOR and SYS_CONFIG_NAME to values set by the ST reference >>>> platforms. Allow changing that by pulling out the >>>> TARGET_STM32MP157C_DK2 and making the ST reference platform settings >>>> conditional on >>>> TARGET_STM32MP157C_DK2 . >>>> Other platforms can now define a different TARGET_ and thus override >>>> the SYS_ settings in their Kconfig. >>> >>> Reviewed-by: Patrick Delaunay <patrick.delaunay at st.com> >>> >>> It seens my configuration between SOC (STM32MP15x) and BOARD is not >> clean... >>> >>> So I prepare a patchset to change it. >>> But I will apply it after your serie... >>> to avoid regression on your board >>> >>> Regards Patrick >> >> Can you apply whatever you feel applicable from the series I posted and push it to >> some git repo, so I don't have to reset all things over and over again ? > > Sure. > > https://gitlab.denx.de/u-boot/custodians/u-boot-stm.git > > => branch master : the paches accepted > [V3] stm32mp1: configs: Make all boot devices in distro boot conditional > > [2/5] ARM: stm32: Allow overriding setup_mac_address() > > They will be included in my next pull request > > => branch next > + my serie = http://patchwork.ozlabs.org/project/uboot/list/?series=152828 > + your serie (including my proposals of update) > http://patchwork.ozlabs.org/project/uboot/list/?series=152293 > > [3/5] ARM: stm32: Fill in missing loadaddr > => I change address to 0xc2000000 > > [5/5] ARM: dts: stm32: Add DH Electronics DHCOM SoM and PDK2 board > I make a lot of modification after my serie and my review.... > > Can you check the delta and tell me if it is working... > > > NB: no more needed after my serie => [1/5] ARM: stm32: Permit multiple board targets i > > PS: [4/5] ARM: dts: stm32: Add missing ETHCK clock to ethernet node > I ma waiting Christophe / kernel feedback.... > Should be OK, thanks.
diff --git a/board/st/stm32mp1/Kconfig b/board/st/stm32mp1/Kconfig index 4fa2360b4f..c84aa41f06 100644 --- a/board/st/stm32mp1/Kconfig +++ b/board/st/stm32mp1/Kconfig @@ -1,4 +1,8 @@ -if TARGET_STM32MP1 +config TARGET_STM32MP157C_DK2 + bool "support of STMicroelectronics STM32MP157C-DK2 Discovery Board" + default y + +if TARGET_STM32MP157C_DK2 config SYS_BOARD default "stm32mp1" @@ -22,8 +26,4 @@ config CMD_STBOARD This compile the stboard command to read and write the board in the OTP. -config TARGET_STM32MP157C_DK2 - bool "support of STMicroelectronics STM32MP157C-DK2 Discovery Board" - default y - endif
Setting TARGET_STM32MP1 in Kconfig always forces SYS_BOARD, SYS_VENDOR and SYS_CONFIG_NAME to values set by the ST reference platforms. Allow changing that by pulling out the TARGET_STM32MP157C_DK2 and making the ST reference platform settings conditional on TARGET_STM32MP157C_DK2 . Other platforms can now define a different TARGET_ and thus override the SYS_ settings in their Kconfig. Signed-off-by: Marek Vasut <marex at denx.de> Cc: Patrick Delaunay <patrick.delaunay at st.com> Cc: Patrice Chotard <patrice.chotard at st.com> --- board/st/stm32mp1/Kconfig | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)