| Message ID | 20200110002839.97868-3-marex@denx.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/5] ARM: stm32: Permit multiple board targets | expand |
Hi Marek, > From: Marek Vasut <marex at denx.de> > Sent: vendredi 10 janvier 2020 01:29 > > Since CONFIG_LOADADDR is not set, the default value of $loadaddr variable is > not set in the environment either. Set the default load address to 256 MiB from the > start of DRAM. > > Signed-off-by: Marek Vasut <marex at denx.de> > Cc: Patrick Delaunay <patrick.delaunay at st.com> > Cc: Patrice Chotard <patrice.chotard at st.com> > --- > include/configs/stm32mp1.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h index > 655833428e..b23dd38794 100644 > --- a/include/configs/stm32mp1.h > +++ b/include/configs/stm32mp1.h > @@ -36,6 +36,7 @@ > * Needed by "loadb" > */ > #define CONFIG_SYS_LOAD_ADDR STM32_DDR_BASE > +#define CONFIG_LOADADDR 0xd0000000 A offset a 256 MiB is really huge... And I don't sure that will fit all the commands (bootm with zImage as it is xpecting to be placed in the first 128 MiB of RAM) and all the products (with lower memory) I propose to have the same value for the 2 defines which define the default loadaddr with 32MB offset (same value that kernel_addr_r). in stm32mp1.h, the defines becomes: /* * default load address used for command tftp, bootm , loadb, ... */ #define CONFIG_LOADADDR 0xc2000000 #define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR Regards Patrick
On 1/13/20 10:06 AM, Patrick DELAUNAY wrote: > Hi Marek, > >> From: Marek Vasut <marex at denx.de> >> Sent: vendredi 10 janvier 2020 01:29 >> >> Since CONFIG_LOADADDR is not set, the default value of $loadaddr variable is >> not set in the environment either. Set the default load address to 256 MiB from the >> start of DRAM. >> >> Signed-off-by: Marek Vasut <marex at denx.de> >> Cc: Patrick Delaunay <patrick.delaunay at st.com> >> Cc: Patrice Chotard <patrice.chotard at st.com> >> --- >> include/configs/stm32mp1.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h index >> 655833428e..b23dd38794 100644 >> --- a/include/configs/stm32mp1.h >> +++ b/include/configs/stm32mp1.h >> @@ -36,6 +36,7 @@ >> * Needed by "loadb" >> */ >> #define CONFIG_SYS_LOAD_ADDR STM32_DDR_BASE >> +#define CONFIG_LOADADDR 0xd0000000 > > A offset a 256 MiB is really huge... > And I don't sure that will fit all the commands (bootm with zImage > as it is xpecting to be placed in the first 128 MiB of RAM) and all the products > (with lower memory) > > I propose to have the same value for the 2 defines which define the default loadaddr > with 32MB offset (same value that kernel_addr_r). That's OK.
Hi Marek, > From: Marek Vasut <marex at denx.de> > Sent: mercredi 15 janvier 2020 10:51 > > On 1/13/20 10:06 AM, Patrick DELAUNAY wrote: > > Hi Marek, > > > >> From: Marek Vasut <marex at denx.de> > >> Sent: vendredi 10 janvier 2020 01:29 > >> > >> Since CONFIG_LOADADDR is not set, the default value of $loadaddr > >> variable is not set in the environment either. Set the default load > >> address to 256 MiB from the start of DRAM. > >> > >> Signed-off-by: Marek Vasut <marex at denx.de> > >> Cc: Patrick Delaunay <patrick.delaunay at st.com> > >> Cc: Patrice Chotard <patrice.chotard at st.com> > >> --- > >> include/configs/stm32mp1.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h > >> index > >> 655833428e..b23dd38794 100644 > >> --- a/include/configs/stm32mp1.h > >> +++ b/include/configs/stm32mp1.h > >> @@ -36,6 +36,7 @@ > >> * Needed by "loadb" > >> */ > >> #define CONFIG_SYS_LOAD_ADDR > STM32_DDR_BASE > >> +#define CONFIG_LOADADDR 0xd0000000 > > > > A offset a 256 MiB is really huge... > > And I don't sure that will fit all the commands (bootm with zImage as > > it is xpecting to be placed in the first 128 MiB of RAM) and all the > > products (with lower memory) > > > > I propose to have the same value for the 2 defines which define the > > default loadaddr with 32MB offset (same value that kernel_addr_r). > > That's OK. I take the patch with thte proposed offset = 32MB. /* - * Needed by "loadb" + * default load address used for command tftp, bootm , loadb, ... */ -#define CONFIG_SYS_LOAD_ADDR STM32_DDR_BASE +#define CONFIG_LOADADDR 0xc2000000 +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR Applied to u-boot-stm32/master, thanks! Regards Patrick
diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h index 655833428e..b23dd38794 100644 --- a/include/configs/stm32mp1.h +++ b/include/configs/stm32mp1.h @@ -36,6 +36,7 @@ * Needed by "loadb" */ #define CONFIG_SYS_LOAD_ADDR STM32_DDR_BASE +#define CONFIG_LOADADDR 0xd0000000 /* ATAGs */ #define CONFIG_CMDLINE_TAG
Since CONFIG_LOADADDR is not set, the default value of $loadaddr variable is not set in the environment either. Set the default load address to 256 MiB from the start of DRAM. Signed-off-by: Marek Vasut <marex at denx.de> Cc: Patrick Delaunay <patrick.delaunay at st.com> Cc: Patrice Chotard <patrice.chotard at st.com> --- include/configs/stm32mp1.h | 1 + 1 file changed, 1 insertion(+)