[RFC,12/16] patman: Add a -D option to enable debugging

Message ID 20200706034203.2171077-13-sjg@chromium.org
State Accepted
Commit 0fc2e632f59050332dbc8e06b561cbe0a0534473
Headers show
Series
  • RFC: patman: Collect review tags and comments from Patchwork
Related show

Commit Message

Simon Glass July 6, 2020, 3:41 a.m.
Most users don't want to see traceback errors. Add an option to enable
them for debugging. Disable them by default.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 tools/patman/main.py | 6 ++++++
 1 file changed, 6 insertions(+)

Patch

diff --git a/tools/patman/main.py b/tools/patman/main.py
index 77f187e769..b96000807e 100755
--- a/tools/patman/main.py
+++ b/tools/patman/main.py
@@ -10,6 +10,7 @@  from argparse import ArgumentParser
 import os
 import re
 import sys
+import traceback
 import unittest
 
 if __name__ == "__main__":
@@ -34,6 +35,8 @@  def AddCommonArgs(parser):
         default=-1, help='Automatically create patches from top n commits')
     parser.add_argument('-e', '--end', type=int, default=0,
         help='Commits to skip at end of patch list')
+    parser.add_argument('-D', '--debug', action='store_true',
+        help='Enabling debugging (provides a full traceback on error)')
     parser.add_argument('-s', '--start', dest='start', type=int,
         default=0, help='Commit to start creating patches from (0 = HEAD)')
 
@@ -98,6 +101,9 @@  if hasattr(args, 'project'):
 if __name__ != "__main__":
     pass
 
+if not args.debug:
+    sys.tracebacklimit = 0
+
 # Run our meagre tests
 if args.cmd == 'test':
     import doctest