diff mbox series

[3/3] msm_gpio: Add support for Qualcomm IPQ40xx

Message ID 20200706083756.6013-3-robert.marko@sartura.hr
State Accepted
Commit 0c7eb6e525decee1b9ce9096888338896ffbb460
Headers show
Series [1/3] arm: Add support for Qualcomm IPQ40xx family | expand

Commit Message

Robert Marko July 6, 2020, 8:37 a.m. UTC
Snapdragon SoCs and IPQ40xx use common TLMM IP,
so existing driver supports IPQ40xx as well.

So lets simply add a compatible for IPQ40xx.

Signed-off-by: Robert Marko <robert.marko at sartura.hr>
---
 doc/device-tree-bindings/gpio/gpio-msm.txt | 3 ++-
 drivers/gpio/msm_gpio.c                    | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Tom Rini July 10, 2020, 3:26 p.m. UTC | #1
On Mon, Jul 06, 2020 at 10:37:56AM +0200, Robert Marko wrote:

> Snapdragon SoCs and IPQ40xx use common TLMM IP,
> so existing driver supports IPQ40xx as well.
> 
> So lets simply add a compatible for IPQ40xx.
> 
> Signed-off-by: Robert Marko <robert.marko at sartura.hr>
> ---
>  doc/device-tree-bindings/gpio/gpio-msm.txt | 3 ++-
>  drivers/gpio/msm_gpio.c                    | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/device-tree-bindings/gpio/gpio-msm.txt b/doc/device-tree-bindings/gpio/gpio-msm.txt
> index 966ce0af09..70a2c7f0dd 100644
> --- a/doc/device-tree-bindings/gpio/gpio-msm.txt
> +++ b/doc/device-tree-bindings/gpio/gpio-msm.txt
> @@ -1,7 +1,8 @@
>  Qualcomm Snapdragon GPIO controller
>  
>  Required properties:
> -- compatible : "qcom,msm8916-pinctrl" or "qcom,apq8016-pinctrl"
> +- compatible : "qcom,msm8916-pinctrl", "qcom,apq8016-pinctrl" or
> +				"qcom,ipq4019-pinctrl"
>  - reg : Physical base address and length of the controller's registers.
>  	This controller is called "Top Level Mode Multiplexing" in
>  	Qualcomm documentation.
> diff --git a/drivers/gpio/msm_gpio.c b/drivers/gpio/msm_gpio.c
> index ac5d20c1b9..868291eddb 100644
> --- a/drivers/gpio/msm_gpio.c
> +++ b/drivers/gpio/msm_gpio.c
> @@ -118,6 +118,7 @@ static int msm_gpio_ofdata_to_platdata(struct udevice *dev)
>  static const struct udevice_id msm_gpio_ids[] = {
>  	{ .compatible = "qcom,msm8916-pinctrl" },
>  	{ .compatible = "qcom,apq8016-pinctrl" },
> +	{ .compatible = "qcom,ipq4019-pinctrl" },
>  	{ }
>  };

Adding the maintainer.
Ramon Fried July 12, 2020, 4:31 a.m. UTC | #2
On Mon, Jul 6, 2020 at 11:38 AM Robert Marko <robert.marko at sartura.hr> wrote:
>
> Snapdragon SoCs and IPQ40xx use common TLMM IP,
> so existing driver supports IPQ40xx as well.
>
> So lets simply add a compatible for IPQ40xx.
>
> Signed-off-by: Robert Marko <robert.marko at sartura.hr>
> ---
>  doc/device-tree-bindings/gpio/gpio-msm.txt | 3 ++-
>  drivers/gpio/msm_gpio.c                    | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/doc/device-tree-bindings/gpio/gpio-msm.txt b/doc/device-tree-bindings/gpio/gpio-msm.txt
> index 966ce0af09..70a2c7f0dd 100644
> --- a/doc/device-tree-bindings/gpio/gpio-msm.txt
> +++ b/doc/device-tree-bindings/gpio/gpio-msm.txt
> @@ -1,7 +1,8 @@
>  Qualcomm Snapdragon GPIO controller
>
>  Required properties:
> -- compatible : "qcom,msm8916-pinctrl" or "qcom,apq8016-pinctrl"
> +- compatible : "qcom,msm8916-pinctrl", "qcom,apq8016-pinctrl" or
> +                               "qcom,ipq4019-pinctrl"
>  - reg : Physical base address and length of the controller's registers.
>         This controller is called "Top Level Mode Multiplexing" in
>         Qualcomm documentation.
> diff --git a/drivers/gpio/msm_gpio.c b/drivers/gpio/msm_gpio.c
> index ac5d20c1b9..868291eddb 100644
> --- a/drivers/gpio/msm_gpio.c
> +++ b/drivers/gpio/msm_gpio.c
> @@ -118,6 +118,7 @@ static int msm_gpio_ofdata_to_platdata(struct udevice *dev)
>  static const struct udevice_id msm_gpio_ids[] = {
>         { .compatible = "qcom,msm8916-pinctrl" },
>         { .compatible = "qcom,apq8016-pinctrl" },
> +       { .compatible = "qcom,ipq4019-pinctrl" },
>         { }
>  };
>
> --
> 2.26.2
>
Reviewed-By: Ramon Fried <rfried.dev at gmail.com>
Tom Rini July 29, 2020, 1:43 p.m. UTC | #3
On Mon, Jul 06, 2020 at 10:37:56AM +0200, Robert Marko wrote:

> Snapdragon SoCs and IPQ40xx use common TLMM IP,

> so existing driver supports IPQ40xx as well.

> 

> So lets simply add a compatible for IPQ40xx.

> 

> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

> Reviewed-By: Ramon Fried <rfried.dev@gmail.com>


Applied to u-boot/master, thanks!

-- 
Tom
diff mbox series

Patch

diff --git a/doc/device-tree-bindings/gpio/gpio-msm.txt b/doc/device-tree-bindings/gpio/gpio-msm.txt
index 966ce0af09..70a2c7f0dd 100644
--- a/doc/device-tree-bindings/gpio/gpio-msm.txt
+++ b/doc/device-tree-bindings/gpio/gpio-msm.txt
@@ -1,7 +1,8 @@ 
 Qualcomm Snapdragon GPIO controller
 
 Required properties:
-- compatible : "qcom,msm8916-pinctrl" or "qcom,apq8016-pinctrl"
+- compatible : "qcom,msm8916-pinctrl", "qcom,apq8016-pinctrl" or
+				"qcom,ipq4019-pinctrl"
 - reg : Physical base address and length of the controller's registers.
 	This controller is called "Top Level Mode Multiplexing" in
 	Qualcomm documentation.
diff --git a/drivers/gpio/msm_gpio.c b/drivers/gpio/msm_gpio.c
index ac5d20c1b9..868291eddb 100644
--- a/drivers/gpio/msm_gpio.c
+++ b/drivers/gpio/msm_gpio.c
@@ -118,6 +118,7 @@  static int msm_gpio_ofdata_to_platdata(struct udevice *dev)
 static const struct udevice_id msm_gpio_ids[] = {
 	{ .compatible = "qcom,msm8916-pinctrl" },
 	{ .compatible = "qcom,apq8016-pinctrl" },
+	{ .compatible = "qcom,ipq4019-pinctrl" },
 	{ }
 };