| Message ID | 20200706200120.23093-9-rasmus.villemoes@prevas.dk |
|---|---|
| State | Superseded |
| Headers | show |
| Series | new rtc methods, rtc command, and tests | expand |
Hello Rasmus, Am 06.07.2020 um 22:01 schrieb Rasmus Villemoes: > It's more natural that any write that happens to touch the reset > register should cause a reset, rather than just a write that starts at > that offset. > > Reviewed-by: Simon Glass <sjg at chromium.org> > Reviewed-by: Heiko Schocher <hs at denx.de> > Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk> > --- > drivers/rtc/i2c_rtc_emul.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to u-boot-i2c.git master Thanks! bye, Heiko
diff --git a/drivers/rtc/i2c_rtc_emul.c b/drivers/rtc/i2c_rtc_emul.c index a010af411b..7f78ff83cb 100644 --- a/drivers/rtc/i2c_rtc_emul.c +++ b/drivers/rtc/i2c_rtc_emul.c @@ -197,7 +197,8 @@ static int sandbox_i2c_rtc_xfer(struct udevice *emul, struct i2c_msg *msg, /* Write the register */ memcpy(plat->reg + offset, ptr, len); - if (offset == REG_RESET) + /* If the reset register was written to, do reset. */ + if (offset <= REG_RESET && REG_RESET < offset + len) reset_time(emul); } }