| Message ID | 1429a64e92548c4ce748ea21556e2edf3c4c7bd0.1594377671.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | 27b4a4abe60ef4f42e45cb33075ca37369831588 |
| Headers | show |
| Series | [v2] serial: Fix SIFIVE debug serial dependency | expand |
On Fri, 10 Jul 2020 at 04:41, Michal Simek <michal.simek at xilinx.com> wrote: > > The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for > debug consoles") has added incorrect dependency for SIFIVE debug uart which > should depend on SIFIVE driver instead of PL01x. > > Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") > Signed-off-by: Michal Simek <michal.simek at xilinx.com> > --- > > Changes in v2: > - Add fixes tag - asked by Simon > > drivers/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass <sjg at chromium.org>
On Fri, Jul 10, 2020 at 6:41 PM Michal Simek <michal.simek@xilinx.com> wrote: > > The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for > debug consoles") has added incorrect dependency for SIFIVE debug uart which > should depend on SIFIVE driver instead of PL01x. > > Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > Changes in v2: > - Add fixes tag - asked by Simon > > drivers/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bin.meng@windriver.com>
On Fri, Jul 10, 2020 at 12:41:13PM +0200, Michal Simek wrote: > The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for > debug consoles") has added incorrect dependency for SIFIVE debug uart which > should depend on SIFIVE driver instead of PL01x. > > Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > Changes in v2: > - Add fixes tag - asked by Simon > > drivers/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig > index 17d0e7362379..006cb5a50140 100644 > --- a/drivers/serial/Kconfig > +++ b/drivers/serial/Kconfig > @@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX > > config DEBUG_UART_SIFIVE > bool "SiFive UART" > - depends on PL01X_SERIAL > + depends on SIFIVE_SERIAL > help > Select this to enable a debug UART using the serial_sifive driver. You > will need to provide parameters to make this work. The driver will > -- > 2.27.0 > Reviewed-by: Leo Liang <ycliang@andestech.com>
On 7/10/20 6:41 AM, Michal Simek wrote: > The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for > debug consoles") has added incorrect dependency for SIFIVE debug uart which > should depend on SIFIVE driver instead of PL01x. > > Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > Changes in v2: > - Add fixes tag - asked by Simon > > drivers/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig > index 17d0e7362379..006cb5a50140 100644 > --- a/drivers/serial/Kconfig > +++ b/drivers/serial/Kconfig > @@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX > > config DEBUG_UART_SIFIVE > bool "SiFive UART" > - depends on PL01X_SERIAL > + depends on SIFIVE_SERIAL > help > Select this to enable a debug UART using the serial_sifive driver. You > will need to provide parameters to make this work. The driver will > Reviewed-by: Sean Anderson <seanga2@gmail.com>
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 17d0e7362379..006cb5a50140 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -359,7 +359,7 @@ config DEBUG_UART_SANDBOX config DEBUG_UART_SIFIVE bool "SiFive UART" - depends on PL01X_SERIAL + depends on SIFIVE_SERIAL help Select this to enable a debug UART using the serial_sifive driver. You will need to provide parameters to make this work. The driver will
The commit 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") has added incorrect dependency for SIFIVE debug uart which should depend on SIFIVE driver instead of PL01x. Fixes: 4cc24aeaf420 ("serial: Add missing Kconfig dependencies for debug consoles") Signed-off-by: Michal Simek <michal.simek at xilinx.com> --- Changes in v2: - Add fixes tag - asked by Simon drivers/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)