| Message ID | 20200712175901.127788-1-jagan@amarulasolutions.com |
|---|---|
| State | Accepted |
| Commit | 7a7f3219a7fb0be5e63df78ee360d9e5466cd908 |
| Headers | show |
| Series | cmd: mvebu/bubt: Drop unused SPI_FLASH_PROTECTION | expand |
On Sun, Jul 12, 2020 at 11:29:01PM +0530, Jagan Teki wrote: > SPI_FLASH_PROTECTION config item is never used in anywhere > in the U-Boot tree. > > Drop it. > > Signed-off-by: Jagan Teki <jagan at amarulasolutions.com> > --- > cmd/mvebu/bubt.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c > index a27b0df8ae..b3b5844267 100644 > --- a/cmd/mvebu/bubt.c > +++ b/cmd/mvebu/bubt.c > @@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size) > return -ENOMEDIUM; > } > > -#ifdef CONFIG_SPI_FLASH_PROTECTION > - spi_flash_protect(flash, 0); > -#endif > erase_bytes = image_size + > (flash->erase_size - image_size % flash->erase_size); > printf("Erasing %d bytes (%d blocks) at offset 0 ...", > @@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size) > else > printf("Done!\n"); > > -#ifdef CONFIG_SPI_FLASH_PROTECTION > - spi_flash_protect(flash, 1); > -#endif > - > return ret; > } Add maintainers.
On 12.07.20 19:59, Jagan Teki wrote: > SPI_FLASH_PROTECTION config item is never used in anywhere > in the U-Boot tree. > > Drop it. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > cmd/mvebu/bubt.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c > index a27b0df8ae..b3b5844267 100644 > --- a/cmd/mvebu/bubt.c > +++ b/cmd/mvebu/bubt.c > @@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size) > return -ENOMEDIUM; > } > > -#ifdef CONFIG_SPI_FLASH_PROTECTION > - spi_flash_protect(flash, 0); > -#endif > erase_bytes = image_size + > (flash->erase_size - image_size % flash->erase_size); > printf("Erasing %d bytes (%d blocks) at offset 0 ...", > @@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size) > else > printf("Done!\n"); > > -#ifdef CONFIG_SPI_FLASH_PROTECTION > - spi_flash_protect(flash, 1); > -#endif > - > return ret; > } > > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
On 06.08.20 14:10, Stefan Roese wrote: > On 12.07.20 19:59, Jagan Teki wrote: >> SPI_FLASH_PROTECTION config item is never used in anywhere >> in the U-Boot tree. >> >> Drop it. >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > Reviewed-by: Stefan Roese <sr@denx.de> Applied to u-boot-marvell/master Thanks, Stefan > Thanks, > Stefan > >> --- >> cmd/mvebu/bubt.c | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c >> index a27b0df8ae..b3b5844267 100644 >> --- a/cmd/mvebu/bubt.c >> +++ b/cmd/mvebu/bubt.c >> @@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size) >> return -ENOMEDIUM; >> } >> -#ifdef CONFIG_SPI_FLASH_PROTECTION >> - spi_flash_protect(flash, 0); >> -#endif >> erase_bytes = image_size + >> (flash->erase_size - image_size % flash->erase_size); >> printf("Erasing %d bytes (%d blocks) at offset 0 ...", >> @@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size) >> else >> printf("Done!\n"); >> -#ifdef CONFIG_SPI_FLASH_PROTECTION >> - spi_flash_protect(flash, 1); >> -#endif >> - >> return ret; >> } >> > > > Viele Grüße, > Stefan > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c index a27b0df8ae..b3b5844267 100644 --- a/cmd/mvebu/bubt.c +++ b/cmd/mvebu/bubt.c @@ -299,9 +299,6 @@ static int spi_burn_image(size_t image_size) return -ENOMEDIUM; } -#ifdef CONFIG_SPI_FLASH_PROTECTION - spi_flash_protect(flash, 0); -#endif erase_bytes = image_size + (flash->erase_size - image_size % flash->erase_size); printf("Erasing %d bytes (%d blocks) at offset 0 ...", @@ -320,10 +317,6 @@ static int spi_burn_image(size_t image_size) else printf("Done!\n"); -#ifdef CONFIG_SPI_FLASH_PROTECTION - spi_flash_protect(flash, 1); -#endif - return ret; }
SPI_FLASH_PROTECTION config item is never used in anywhere in the U-Boot tree. Drop it. Signed-off-by: Jagan Teki <jagan at amarulasolutions.com> --- cmd/mvebu/bubt.c | 7 ------- 1 file changed, 7 deletions(-)