diff mbox series

[v2,2/8] arm64: dts: rk3399-puma: fix gpio levels for vcc5v0-host regulator

Message ID 20200604100908.468659-3-heiko@sntech.de
State Superseded
Headers show
Series revive Theobroma-Systems puma board | expand

Commit Message

Heiko Stuebner June 4, 2020, 10:09 a.m. UTC
From: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>

The regulator enable-gpio uses opposite values for the declaration
vs. the enable_active_low property, breaking the regulator enablement.

Make the usbhost-supply work again by bringing them in sync again.

This mimics the upstream Linux change found on:
http://lore.kernel.org/r/20200604091239.424318-1-heiko at sntech.de

Signed-off-by: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>
---
 arch/arm/dts/rk3399-puma.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kever Yang June 5, 2020, 2:22 a.m. UTC | #1
On 2020/6/4 ??6:09, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>
>
> The regulator enable-gpio uses opposite values for the declaration
> vs. the enable_active_low property, breaking the regulator enablement.
>
> Make the usbhost-supply work again by bringing them in sync again.
>
> This mimics the upstream Linux change found on:
> http://lore.kernel.org/r/20200604091239.424318-1-heiko at sntech.de
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner at theobroma-systems.com>

Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk3399-puma.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi
> index 531520e771..72c06abd27 100644
> --- a/arch/arm/dts/rk3399-puma.dtsi
> +++ b/arch/arm/dts/rk3399-puma.dtsi
> @@ -101,7 +101,7 @@
>   
>   	vcc5v0_host: vcc5v0-host-regulator {
>   		compatible = "regulator-fixed";
> -		gpio = <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>;
> +		gpio = <&gpio4 RK_PA3 GPIO_ACTIVE_LOW>;
>   		enable-active-low;
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&vcc5v0_host_en>;
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3399-puma.dtsi b/arch/arm/dts/rk3399-puma.dtsi
index 531520e771..72c06abd27 100644
--- a/arch/arm/dts/rk3399-puma.dtsi
+++ b/arch/arm/dts/rk3399-puma.dtsi
@@ -101,7 +101,7 @@ 
 
 	vcc5v0_host: vcc5v0-host-regulator {
 		compatible = "regulator-fixed";
-		gpio = <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio4 RK_PA3 GPIO_ACTIVE_LOW>;
 		enable-active-low;
 		pinctrl-names = "default";
 		pinctrl-0 = <&vcc5v0_host_en>;