diff mbox series

[v1,39/43] x86: Update the comment about booting for FSP2

Message ID 20200615035738.248710-20-sjg@chromium.org
State Accepted
Commit 538c9b3d29d3777ff168b2341eacb5554791fc4e
Headers show
Series x86: Programmatic generation of ACPI tables (Part C) | expand

Commit Message

Simon Glass June 15, 2020, 3:57 a.m. UTC
The comment here applies only to FSP1, so update it.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 arch/x86/cpu/start.S | 1 +
 1 file changed, 1 insertion(+)

Comments

Wolfgang Wallner June 25, 2020, 12:46 p.m. UTC | #1
Hi Simon,

-----"Simon Glass" <sjg at chromium.org> schrieb: -----
> Betreff: [PATCH v1 39/43] x86: Update the comment about booting for FSP2
> 
> The comment here applies only to FSP1, so update it.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
>  arch/x86/cpu/start.S | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S
> index 01524635e9..4ad515ce08 100644
> --- a/arch/x86/cpu/start.S
> +++ b/arch/x86/cpu/start.S
> @@ -124,6 +124,7 @@ car_init_ret:
>  #endif
>  #else
>  	/*
> +	 * Instructions for FSP1, but not FSP2:
>  	 * U-Boot enters here twice. For the first time it comes from
>  	 * car_init_done() with esp points to a temporary stack and esi
>  	 * set to zero. For the second time it comes from fsp_init_done()
> -- 
> 2.27.0.290.gba653c62da-goog

Reviewed-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
Bin Meng June 30, 2020, 8:40 a.m. UTC | #2
On Mon, Jun 15, 2020 at 11:58 AM Simon Glass <sjg at chromium.org> wrote:
>
> The comment here applies only to FSP1, so update it.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  arch/x86/cpu/start.S | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
diff mbox series

Patch

diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S
index 01524635e9..4ad515ce08 100644
--- a/arch/x86/cpu/start.S
+++ b/arch/x86/cpu/start.S
@@ -124,6 +124,7 @@  car_init_ret:
 #endif
 #else
 	/*
+	 * Instructions for FSP1, but not FSP2:
 	 * U-Boot enters here twice. For the first time it comes from
 	 * car_init_done() with esp points to a temporary stack and esi
 	 * set to zero. For the second time it comes from fsp_init_done()