| Message ID | 20200310233454.18172-1-s-anna@ti.com |
|---|---|
| State | Accepted |
| Commit | 0438a0a181675cb5d149184d8a6e50678cbc6d15 |
| Headers | show |
| Series | remoteproc: k3-r5: Fix rproc init failure for Main R5FSS0 | expand |
On 11/03/20 5:04 AM, Suman Anna wrote: > The Main R5FSS0 cluster is also enabled to probe the R5F remoteproc > driver within R5 SPL for booting the Core0 very early. This results > in a ti_sci_power_domain_on failure during the probe from the A72 > U-Boot when "rproc init" is executed at U-Boot prompt, and doesn't > enumerate all the rproc devices. > > Fix this by suppressing the power_domain_on altogether using the > flag DM_FLAG_DEFAULT_PD_CTRL_OFF added in commit af94ad418dc7 > ("dm: core: Allow for not controlling the power-domain by DM framework"). > > Fixes: fac6aa817a09 ("configs: j721e_evm_r5: Enable R5F remoteproc support") > Signed-off-by: Suman Anna <s-anna at ti.com> > --- > Hi Lokesh, > > The recently staged R5 SPL remoteproc boot support causes the rproc init > command to fail on U-Boot prompt. This is a fix for the same. Patch is > against ti/next branch. Applied to u-boot-ti/next Thanks and regards, Lokesh
diff --git a/drivers/remoteproc/ti_k3_r5f_rproc.c b/drivers/remoteproc/ti_k3_r5f_rproc.c index ea56689552aa..2e2665f3750d 100644 --- a/drivers/remoteproc/ti_k3_r5f_rproc.c +++ b/drivers/remoteproc/ti_k3_r5f_rproc.c @@ -816,4 +816,5 @@ U_BOOT_DRIVER(k3_r5fss) = { .id = UCLASS_MISC, .probe = k3_r5f_cluster_probe, .priv_auto_alloc_size = sizeof(struct k3_r5f_cluster), + .flags = DM_FLAG_DEFAULT_PD_CTRL_OFF, };
The Main R5FSS0 cluster is also enabled to probe the R5F remoteproc driver within R5 SPL for booting the Core0 very early. This results in a ti_sci_power_domain_on failure during the probe from the A72 U-Boot when "rproc init" is executed at U-Boot prompt, and doesn't enumerate all the rproc devices. Fix this by suppressing the power_domain_on altogether using the flag DM_FLAG_DEFAULT_PD_CTRL_OFF added in commit af94ad418dc7 ("dm: core: Allow for not controlling the power-domain by DM framework"). Fixes: fac6aa817a09 ("configs: j721e_evm_r5: Enable R5F remoteproc support") Signed-off-by: Suman Anna <s-anna at ti.com> --- Hi Lokesh, The recently staged R5 SPL remoteproc boot support causes the rproc init command to fail on U-Boot prompt. This is a fix for the same. Patch is against ti/next branch. regards Suman drivers/remoteproc/ti_k3_r5f_rproc.c | 1 + 1 file changed, 1 insertion(+)