| Message ID | 1583949861-19143-11-git-send-email-amittomer25@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Actions S700 SoC support | expand |
On Wed, 11 Mar 2020 23:34:20 +0530 Amit Singh Tomar <amittomer25 at gmail.com> wrote: > The Cubieboard is a single board computer containing a > Actions S700 SoC(with 4 ARMv8 Cortex-A53 cores). > > This patch adds respective defconfig alongwith device tree(sync with > Linux v5.5-rc6). The .dts copy is correct. > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org> > Signed-off-by: Amit Singh Tomar <amittomer25 at gmail.com> > --- > Changes since v4: > * No changes. > Changes since v3: > * added reviewed-by: tag. > Changes since v2: > * No changes. > Changes since v1: > * No changes. > --- > arch/arm/dts/s700-cubieboard7.dts | 92 +++++++++++++++++++++++++++++++++++++++ > configs/cubieboard7_defconfig | 16 +++++++ > 2 files changed, 108 insertions(+) > create mode 100644 arch/arm/dts/s700-cubieboard7.dts > create mode 100644 configs/cubieboard7_defconfig > > diff --git a/arch/arm/dts/s700-cubieboard7.dts b/arch/arm/dts/s700-cubieboard7.dts > new file mode 100644 > index 0000000..63e375c > --- /dev/null > +++ b/arch/arm/dts/s700-cubieboard7.dts > @@ -0,0 +1,92 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2017 Andreas F?rber > + */ > + > +/dts-v1/; > + > +#include "s700.dtsi" > + > +/ { > + compatible = "cubietech,cubieboard7", "actions,s700"; > + model = "CubieBoard7"; > + > + aliases { > + serial3 = &uart3; > + }; > + > + chosen { > + stdout-path = "serial3:115200n8"; > + }; > + > + memory at 0 { > + device_type = "memory"; > + reg = <0x0 0x0 0x0 0x80000000>; > + }; > + > + memory at 1,e0000000 { > + device_type = "memory"; > + reg = <0x1 0xe0000000 0x0 0x0>; > + }; > +}; > + > +&i2c0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_default>; > +}; > + > +&i2c1 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_default>; > +}; > + > +&i2c2 { > + status = "disabled"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c2_default>; > +}; > + > +&pinctrl { > + i2c0_default: i2c0_default { > + pinmux { > + groups = "i2c0_mfp"; > + function = "i2c0"; > + }; > + pinconf { > + pins = "i2c0_sclk", "i2c0_sdata"; > + bias-pull-up; > + }; > + }; > + > + i2c1_default: i2c1_default { > + pinmux { > + groups = "i2c1_dummy"; > + function = "i2c1"; > + }; > + pinconf { > + pins = "i2c1_sclk", "i2c1_sdata"; > + bias-pull-up; > + }; > + }; > + > + i2c2_default: i2c2_default { > + pinmux { > + groups = "i2c2_dummy"; > + function = "i2c2"; > + }; > + pinconf { > + pins = "i2c2_sclk", "i2c2_sdata"; > + bias-pull-up; > + }; > + }; > +}; > + > +&timer { > + clocks = <&hosc>; > +}; > + > +&uart3 { > + status = "okay"; > +}; > diff --git a/configs/cubieboard7_defconfig b/configs/cubieboard7_defconfig > new file mode 100644 > index 0000000..0459997 > --- /dev/null > +++ b/configs/cubieboard7_defconfig > @@ -0,0 +1,16 @@ > +CONFIG_ARM=y > +CONFIG_ARCH_OWL=y > +CONFIG_MACH_S700=y > +CONFIG_IDENT_STRING="\ncubieboard7" > +CONFIG_DISTRO_DEFAULTS=y > +CONFIG_NR_DRAM_BANKS=1 > +CONFIG_BOOTDELAY=5 > +CONFIG_USE_BOOTARGS=y > +CONFIG_BOOTARGS="console=ttyOWL3,115200n8" > +# CONFIG_DISPLAY_CPUINFO is not set > +# CONFIG_DISPLAY_BOARDINFO is not set > +CONFIG_SYS_PROMPT="U-Boot => " > +CONFIG_CMD_MD5SUM=y > +CONFIG_CMD_MEMINFO=y > +CONFIG_CMD_TIMER=y > +CONFIG_DEFAULT_DEVICE_TREE="s700-cubieboard7" This seems quite bloated, also containing some common options, which are not board specific. Since this is only the second Owl board, it would be a good opportunity to generalise this: Move CONFIG_DISTRO_DEFAULTS, CONFIG_NR_DRAM_BANKS, CONFIG_SYS_PROMPT and CONFIG_SYS_RELOC_GD_ENV_ADDR into arch/arm/mach-owl/Kconfig, by adding a stanza for each like this: config CONFIG_DISTRO_DEFAULTS default y Possibly CONFIG_DISPLAY_CPUINFO and CONFIG_DISPLAY_BOARDINFO could be moved also. Also I am not sure why we need MD5SUM, MEMINFO and TIMER commands. Cheers, Andre
diff --git a/arch/arm/dts/s700-cubieboard7.dts b/arch/arm/dts/s700-cubieboard7.dts new file mode 100644 index 0000000..63e375c --- /dev/null +++ b/arch/arm/dts/s700-cubieboard7.dts @@ -0,0 +1,92 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2017 Andreas F?rber + */ + +/dts-v1/; + +#include "s700.dtsi" + +/ { + compatible = "cubietech,cubieboard7", "actions,s700"; + model = "CubieBoard7"; + + aliases { + serial3 = &uart3; + }; + + chosen { + stdout-path = "serial3:115200n8"; + }; + + memory at 0 { + device_type = "memory"; + reg = <0x0 0x0 0x0 0x80000000>; + }; + + memory at 1,e0000000 { + device_type = "memory"; + reg = <0x1 0xe0000000 0x0 0x0>; + }; +}; + +&i2c0 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_default>; +}; + +&i2c1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_default>; +}; + +&i2c2 { + status = "disabled"; + pinctrl-names = "default"; + pinctrl-0 = <&i2c2_default>; +}; + +&pinctrl { + i2c0_default: i2c0_default { + pinmux { + groups = "i2c0_mfp"; + function = "i2c0"; + }; + pinconf { + pins = "i2c0_sclk", "i2c0_sdata"; + bias-pull-up; + }; + }; + + i2c1_default: i2c1_default { + pinmux { + groups = "i2c1_dummy"; + function = "i2c1"; + }; + pinconf { + pins = "i2c1_sclk", "i2c1_sdata"; + bias-pull-up; + }; + }; + + i2c2_default: i2c2_default { + pinmux { + groups = "i2c2_dummy"; + function = "i2c2"; + }; + pinconf { + pins = "i2c2_sclk", "i2c2_sdata"; + bias-pull-up; + }; + }; +}; + +&timer { + clocks = <&hosc>; +}; + +&uart3 { + status = "okay"; +}; diff --git a/configs/cubieboard7_defconfig b/configs/cubieboard7_defconfig new file mode 100644 index 0000000..0459997 --- /dev/null +++ b/configs/cubieboard7_defconfig @@ -0,0 +1,16 @@ +CONFIG_ARM=y +CONFIG_ARCH_OWL=y +CONFIG_MACH_S700=y +CONFIG_IDENT_STRING="\ncubieboard7" +CONFIG_DISTRO_DEFAULTS=y +CONFIG_NR_DRAM_BANKS=1 +CONFIG_BOOTDELAY=5 +CONFIG_USE_BOOTARGS=y +CONFIG_BOOTARGS="console=ttyOWL3,115200n8" +# CONFIG_DISPLAY_CPUINFO is not set +# CONFIG_DISPLAY_BOARDINFO is not set +CONFIG_SYS_PROMPT="U-Boot => " +CONFIG_CMD_MD5SUM=y +CONFIG_CMD_MEMINFO=y +CONFIG_CMD_TIMER=y +CONFIG_DEFAULT_DEVICE_TREE="s700-cubieboard7"