| Message ID | 20200311221118.4579-2-trini@konsulko.com |
|---|---|
| State | Accepted |
| Commit | d91cf006ee42c914573faeff3ca5a5a64ea71d8f |
| Headers | show |
| Series | [PATCHv2,1/8] spl: Kconfig: Escape '$(ARCH)' in LDSCRIPT entries | expand |
> From: Tom Rini [mailto:trini at konsulko.com] > Sent: Thursday, March 12, 2020 6:11 AM > To: u-boot at lists.denx.de > Cc: Michal Simek; Rick Jian-Zhi Chen(???); Philippe Reynes; Eric Jarrige > Subject: [PATCHv2 2/8] Kconfig: Remove redundant variable sets > > In a few places we have Kconfig entries that set SPL_LDSCRIPT to what is the default value anyways. Drop these. > > Cc: Michal Simek <monstr at monstr.eu> > Cc: Rick Chen <rick at andestech.com> > Cc: Philippe Reynes <tremyfr at yahoo.fr> > Cc: Eric Jarrige <eric.jarrige at armadeus.org> > Signed-off-by: Tom Rini <trini at konsulko.com> > --- > arch/microblaze/Kconfig | 3 --- > arch/riscv/Kconfig | 3 --- > board/armadeus/apf27/Kconfig | 3 --- > 3 files changed, 9 deletions(-) > > diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig index 5ce8261451d3..2bd260e5d76e 100644 > --- a/arch/microblaze/Kconfig > +++ b/arch/microblaze/Kconfig > @@ -30,7 +30,4 @@ config STACK_SIZE > > source "board/xilinx/microblaze-generic/Kconfig" > > -config SPL_LDSCRIPT > - default "arch/microblaze/cpu/u-boot-spl.lds" > - > endmenu > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 3338b788f84a..f49618d24d26 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -229,7 +229,4 @@ config STACK_SIZE_SHIFT > int > default 14 > > -config SPL_LDSCRIPT > - default "arch/riscv/cpu/u-boot-spl.lds" > - Reviewed-by: Rick Chen <rick at andestech.com>
On 11. 03. 20 23:11, Tom Rini wrote: > In a few places we have Kconfig entries that set SPL_LDSCRIPT to what is > the default value anyways. Drop these. > > Cc: Michal Simek <monstr at monstr.eu> > Cc: Rick Chen <rick at andestech.com> > Cc: Philippe Reynes <tremyfr at yahoo.fr> > Cc: Eric Jarrige <eric.jarrige at armadeus.org> > Signed-off-by: Tom Rini <trini at konsulko.com> > --- > arch/microblaze/Kconfig | 3 --- > arch/riscv/Kconfig | 3 --- > board/armadeus/apf27/Kconfig | 3 --- > 3 files changed, 9 deletions(-) > > diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig > index 5ce8261451d3..2bd260e5d76e 100644 > --- a/arch/microblaze/Kconfig > +++ b/arch/microblaze/Kconfig > @@ -30,7 +30,4 @@ config STACK_SIZE > > source "board/xilinx/microblaze-generic/Kconfig" > > -config SPL_LDSCRIPT > - default "arch/microblaze/cpu/u-boot-spl.lds" > - Reviewed-by: Michal Simek <michal.simek at xilinx.com> (for Microblaze) Thanks, Michal
On Thu, Mar 12, 2020 at 7:11 AM Tom Rini <trini at konsulko.com> wrote: > > In a few places we have Kconfig entries that set SPL_LDSCRIPT to what is > the default value anyways. Drop these. > > Cc: Michal Simek <monstr at monstr.eu> > Cc: Rick Chen <rick at andestech.com> > Cc: Philippe Reynes <tremyfr at yahoo.fr> > Cc: Eric Jarrige <eric.jarrige at armadeus.org> > Signed-off-by: Tom Rini <trini at konsulko.com> > -- Reviewed-by: Masahiro Yamada <masahiroy at kernel.org>
On Wed, Mar 11, 2020 at 06:11:12PM -0400, Tom Rini wrote: > In a few places we have Kconfig entries that set SPL_LDSCRIPT to what is > the default value anyways. Drop these. > > Cc: Michal Simek <monstr at monstr.eu> > Cc: Rick Chen <rick at andestech.com> > Cc: Philippe Reynes <tremyfr at yahoo.fr> > Cc: Eric Jarrige <eric.jarrige at armadeus.org> > Signed-off-by: Tom Rini <trini at konsulko.com> > Reviewed-by: Rick Chen <rick at andestech.com> > Reviewed-by: Michal Simek <michal.simek at xilinx.com> (for Microblaze) > Reviewed-by: Masahiro Yamada <masahiroy at kernel.org> Applied to u-boot/next, thanks!
diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig index 5ce8261451d3..2bd260e5d76e 100644 --- a/arch/microblaze/Kconfig +++ b/arch/microblaze/Kconfig @@ -30,7 +30,4 @@ config STACK_SIZE source "board/xilinx/microblaze-generic/Kconfig" -config SPL_LDSCRIPT - default "arch/microblaze/cpu/u-boot-spl.lds" - endmenu diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 3338b788f84a..f49618d24d26 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -229,7 +229,4 @@ config STACK_SIZE_SHIFT int default 14 -config SPL_LDSCRIPT - default "arch/riscv/cpu/u-boot-spl.lds" - endmenu diff --git a/board/armadeus/apf27/Kconfig b/board/armadeus/apf27/Kconfig index a342d2e05ec5..65544a844834 100644 --- a/board/armadeus/apf27/Kconfig +++ b/board/armadeus/apf27/Kconfig @@ -1,8 +1,5 @@ if TARGET_APF27 -config SPL_LDSCRIPT - default "arch/$(ARCH)/cpu/u-boot-spl.lds" - config SYS_BOARD default "apf27"
In a few places we have Kconfig entries that set SPL_LDSCRIPT to what is the default value anyways. Drop these. Cc: Michal Simek <monstr at monstr.eu> Cc: Rick Chen <rick at andestech.com> Cc: Philippe Reynes <tremyfr at yahoo.fr> Cc: Eric Jarrige <eric.jarrige at armadeus.org> Signed-off-by: Tom Rini <trini at konsulko.com> --- arch/microblaze/Kconfig | 3 --- arch/riscv/Kconfig | 3 --- board/armadeus/apf27/Kconfig | 3 --- 3 files changed, 9 deletions(-)