| Message ID | 1584475636-24521-3-git-send-email-twarren@nvidia.com |
|---|---|
| State | Accepted |
| Commit | 224595abaae918a64fba2625553e51a482ead084 |
| Headers | show |
| Series | net: tegra: Misc network fixes | expand |
On 3/17/20 2:07 PM, twarren at nvidia.com wrote: > From: Tom Warren <twarren at nvidia.com> > > This allows the user to set $serverip in the environment before > executing a DHCP request. If they do, U-Boot will use that IP rather > than using the IP in the DHCP response. Acked-by: Stephen Warren <swarren at nvidia.com> I wonder if this should be applied to more Tegra boards, so they all work consistently? E.g. T20/30/114/124 boards.
-----Original Message----- From: Stephen Warren <swarren at wwwdotorg.org> Sent: Wednesday, March 18, 2020 4:31 PM To: Tom Warren <TWarren at nvidia.com> Cc: u-boot at lists.denx.de; Stephen Warren <swarren at nvidia.com>; Thierry Reding <treding at nvidia.com>; Jonathan Hunter <jonathanh at nvidia.com>; tomcwarren3959 at gmail.com Subject: Re: [PATCH 2/2] tegra: Enable CONFIG_BOOTP_PREFER_SERVERIP for all boards External email: Use caution opening links or attachments On 3/17/20 2:07 PM, twarren at nvidia.com wrote: > From: Tom Warren <twarren at nvidia.com> > > This allows the user to set $serverip in the environment before > executing a DHCP request. If they do, U-Boot will use that IP rather > than using the IP in the DHCP response. Acked-by: Stephen Warren <swarren at nvidia.com> I wonder if this should be applied to more Tegra boards, so they all work consistently? E.g. T20/30/114/124 boards. [Tom] I can certainly do that, but I don't really test on anything <T210 anymore, especially not net boot. Do you test for that in your Jenkins test harness? ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------
On 3/18/20 5:52 PM, Tom Warren wrote: > -----Original Message----- > From: Stephen Warren <swarren at wwwdotorg.org> > Sent: Wednesday, March 18, 2020 4:31 PM > To: Tom Warren <TWarren at nvidia.com> > Cc: u-boot at lists.denx.de; Stephen Warren <swarren at nvidia.com>; Thierry Reding <treding at nvidia.com>; Jonathan Hunter <jonathanh at nvidia.com>; tomcwarren3959 at gmail.com > Subject: Re: [PATCH 2/2] tegra: Enable CONFIG_BOOTP_PREFER_SERVERIP for all boards > > External email: Use caution opening links or attachments > > > On 3/17/20 2:07 PM, twarren at nvidia.com wrote: >> From: Tom Warren <twarren at nvidia.com> >> >> This allows the user to set $serverip in the environment before >> executing a DHCP request. If they do, U-Boot will use that IP rather >> than using the IP in the DHCP response. > > Acked-by: Stephen Warren <swarren at nvidia.com> > > I wonder if this should be applied to more Tegra boards, so they all work consistently? E.g. T20/30/114/124 boards. > [Tom] I can certainly do that, but I don't really test on anything <T210 anymore, especially not net boot. Do you test for that in your Jenkins test harness? The oldest hardware that's tested in Jenkins is Jetson TK1. In total I have TK1, TX1, TX2 automated.
diff --git a/configs/e2220-1170_defconfig b/configs/e2220-1170_defconfig index 1639040..951ed1d 100644 --- a/configs/e2220-1170_defconfig +++ b/configs/e2220-1170_defconfig @@ -43,3 +43,4 @@ CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX=y +CONFIG_BOOTP_PREFER_SERVERIP=y diff --git a/configs/p2371-0000_defconfig b/configs/p2371-0000_defconfig index 2070199..7081719 100644 --- a/configs/p2371-0000_defconfig +++ b/configs/p2371-0000_defconfig @@ -44,3 +44,4 @@ CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX=y +CONFIG_BOOTP_PREFER_SERVERIP=y diff --git a/configs/p2371-2180_defconfig b/configs/p2371-2180_defconfig index 8c808ae..c70217c 100644 --- a/configs/p2371-2180_defconfig +++ b/configs/p2371-2180_defconfig @@ -52,3 +52,4 @@ CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX=y +CONFIG_BOOTP_PREFER_SERVERIP=y diff --git a/configs/p2571_defconfig b/configs/p2571_defconfig index 721c5c5..43c24b8 100644 --- a/configs/p2571_defconfig +++ b/configs/p2571_defconfig @@ -44,3 +44,4 @@ CONFIG_CI_UDC=y CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_USB_HOST_ETHER=y CONFIG_USB_ETHER_ASIX=y +CONFIG_BOOTP_PREFER_SERVERIP=y diff --git a/configs/p2771-0000-000_defconfig b/configs/p2771-0000-000_defconfig index e347a77..8bf8419 100644 --- a/configs/p2771-0000-000_defconfig +++ b/configs/p2771-0000-000_defconfig @@ -37,3 +37,4 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_POSITION_INDEPENDENT=y +CONFIG_BOOTP_PREFER_SERVERIP=y diff --git a/configs/p2771-0000-500_defconfig b/configs/p2771-0000-500_defconfig index 0803b26..1f40333 100644 --- a/configs/p2771-0000-500_defconfig +++ b/configs/p2771-0000-500_defconfig @@ -37,3 +37,4 @@ CONFIG_SYS_NS16550=y CONFIG_USB=y CONFIG_DM_USB=y CONFIG_POSITION_INDEPENDENT=y +CONFIG_BOOTP_PREFER_SERVERIP=y