| Message ID | 20200325184501.200580-1-marex@denx.de |
|---|---|
| State | Accepted |
| Commit | e3b54cda6893726703a1fae66e9521bc231464cf |
| Headers | show |
| Series | [01/12] net: ks8851: Replace malloc()+memset() with calloc() | expand |
diff --git a/drivers/net/ks8851_mll.c b/drivers/net/ks8851_mll.c index 718a7dd019..4386763bac 100644 --- a/drivers/net/ks8851_mll.c +++ b/drivers/net/ks8851_mll.c @@ -602,12 +602,9 @@ int ks8851_mll_initialize(u8 dev_num, int base_addr) { struct eth_device *dev; - dev = malloc(sizeof(*dev)); - if (!dev) { - printf("Error: Failed to allocate memory\n"); - return -1; - } - memset(dev, 0, sizeof(*dev)); + dev = calloc(1, sizeof(*dev)); + if (!dev) + return -ENOMEM; dev->iobase = base_addr;
Replace combination of malloc()+memset() with calloc() as the behavior is exactly the same and the amount of code is reduced. Moreover, remove printf() in the fail path, as it is useless, and return proper -ENOMEM return code. Signed-off-by: Marek Vasut <marex at denx.de> Cc: Eugen Hristev <eugen.hristev at microchip.com> Cc: Joe Hershberger <joe.hershberger at ni.com> --- drivers/net/ks8851_mll.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)