| Message ID | 1392674322-9036-15-git-send-email-john.stultz@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On 02/18/2014 04:18 PM, Arve Hjønnevåg wrote: > On Mon, Feb 17, 2014 at 1:58 PM, John Stultz <john.stultz@linaro.org> wrote: >> Add a more clear explanation of the option in the prompt, and >> make the config depend on ANDROID_BINDER_IPC being selected. >> >> Also sets the default to y, which matches AOSP. >> > I don't know if you want the default to be y. By the time this kernel > is used, the user-space default may have switched to using the 64 bit > interface by default. The android-3.10 kernel currently defaulting to > y since it may get used with a 4.4 android user-space, and because the > 32 bit arm kernel is missing the 8 byte get_user variant that it > needs. My thought is that currently folks who might be using the upstream kernel would experience less friction, as they are likely to be using the current userspace. Once the new userspace with the 64bit aware binder is commonly available, removing the "default y" makes sense. But until then it seems having a new config that defaults to n and breaks existing users might be viewed as "unfriendly" :) Does that seem reasonable? thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig index 78e82f5..0dc8ed7 100644 --- a/drivers/staging/android/Kconfig +++ b/drivers/staging/android/Kconfig @@ -21,8 +21,9 @@ config ANDROID_BINDER_IPC between said processes. config ANDROID_BINDER_IPC_32BIT - bool "Use old 32-bit binder api" - depends on !64BIT + bool "Use old (Android 4.4 and earlier) 32-bit binder API" + depends on !64BIT && ANDROID_BINDER_IPC + default y ---help--- The Binder API has been changed to support both 32 and 64bit applications in a mixed environment.
Add a more clear explanation of the option in the prompt, and make the config depend on ANDROID_BINDER_IPC being selected. Also sets the default to y, which matches AOSP. Cc: Greg KH <gregkh@linuxfoundation.org> Cc: Colin Cross <ccross@android.com> Cc: Arve Hjønnevåg <arve@android.com> Cc: Android Kernel Team <kernel-team@android.com> Signed-off-by: John Stultz <john.stultz@linaro.org> --- drivers/staging/android/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)