| Message ID | 20201001070911.140019-1-vkoul@kernel.org |
|---|---|
| State | Accepted |
| Commit | 60f5a24c11f7fa0c8c74018cfd4c25a3f432fdaf |
| Headers | show |
| Series | phy: qcom-qmp: initialize the pointer to NULL | expand |
Quoting Vinod Koul (2020-10-01 00:09:11) > Smatch complains: > drivers/phy/qualcomm/phy-qcom-qmp.c:3899 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_cfg'. > drivers/phy/qualcomm/phy-qcom-qmp.c:3900 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_serdes'. > drivers/phy/qualcomm/phy-qcom-qmp.c:3902 qcom_qmp_phy_probe() error: uninitialized symbol 'usb_cfg'. > > This is a warning but not a practical one as dp_cfg, dp_serdes and > usb_cfg will be set and used when valid. So we can set the pointers to > NULL to quiesce the warnings. > > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy") > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- Thanks! Reviewed-by: Stephen Boyd <swboyd@chromium.org>
On 01-10-20, 00:23, Stephen Boyd wrote: > Quoting Vinod Koul (2020-10-01 00:09:11) > > Smatch complains: > > drivers/phy/qualcomm/phy-qcom-qmp.c:3899 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_cfg'. > > drivers/phy/qualcomm/phy-qcom-qmp.c:3900 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_serdes'. > > drivers/phy/qualcomm/phy-qcom-qmp.c:3902 qcom_qmp_phy_probe() error: uninitialized symbol 'usb_cfg'. > > > > This is a warning but not a practical one as dp_cfg, dp_serdes and > > usb_cfg will be set and used when valid. So we can set the pointers to > > NULL to quiesce the warnings. > > > > Reported-by: kernel test robot <lkp@intel.com> > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > > Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy") > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > Thanks! > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Thanks for quick review, applied and pushed now
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 6171b44da050..5d33ad4d06f2 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -3928,9 +3928,9 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev) void __iomem *usb_serdes; void __iomem *dp_serdes; const struct qmp_phy_combo_cfg *combo_cfg = NULL; - const struct qmp_phy_cfg *cfg; - const struct qmp_phy_cfg *usb_cfg; - const struct qmp_phy_cfg *dp_cfg; + const struct qmp_phy_cfg *cfg = NULL; + const struct qmp_phy_cfg *usb_cfg = NULL; + const struct qmp_phy_cfg *dp_cfg = NULL; int num, id, expected_phys; int ret;
Smatch complains: drivers/phy/qualcomm/phy-qcom-qmp.c:3899 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_cfg'. drivers/phy/qualcomm/phy-qcom-qmp.c:3900 qcom_qmp_phy_probe() error: uninitialized symbol 'dp_serdes'. drivers/phy/qualcomm/phy-qcom-qmp.c:3902 qcom_qmp_phy_probe() error: uninitialized symbol 'usb_cfg'. This is a warning but not a practical one as dp_cfg, dp_serdes and usb_cfg will be set and used when valid. So we can set the pointers to NULL to quiesce the warnings. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Fixes: 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo phy") Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/phy/qualcomm/phy-qcom-qmp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)