[Xen-devel,linux-linus,test] 25278: regressions - FAIL

Message ID 1393235457.16570.10.camel@kazak.uk.xensource.com
State New
Headers show

Commit Message

Ian Campbell Feb. 24, 2014, 9:50 a.m.
On Sun, 2014-02-23 at 17:32 +0000, xen.org wrote:

>  build-armhf-pvops             4 kernel-build                 fail   never pass 

This is:
        ERROR: "__bad_udelay" [drivers/scsi/bfa/bfa.ko] undefined!
which is a deliberately forced link error due to over large udelay
parameter (see also
http://osdir.com/ml/scm-fedora-commits/2014-01/msg14211.html)

I could do this for ARM only if you prefer, but in the first instance
that seemed like unnecessary faff..

8<-----------------------

From e3d00b001e57ab862032afd5d8d74183e52917a2 Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@citrix.com>
Date: Mon, 24 Feb 2014 09:42:28 +0000
Subject: [PATCH] Disable "Brocade BFA Fibre Channel Support"

This driver is broken on ARM:
    ERROR: "__bad_udelay" [drivers/scsi/bfa/bfa.ko] undefined!

I've taken the lazy way out and disabled it on all platforms. I think it isn't
especially likely that any of the current osstest hosts are using Fibre
Channel right now. The code to enable it came from a big batch addition of
drivers in 451f39c6149e.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 ts-kernel-build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ian Campbell Feb. 24, 2014, 11:36 a.m. | #1
On Mon, 2014-02-24 at 11:31 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [linux-linus test] 25278: regressions - FAIL"):
> > On Sun, 2014-02-23 at 17:32 +0000, xen.org wrote:
> > >  build-armhf-pvops             4 kernel-build                 fail   never pass 
> > 
> > This is:
> >         ERROR: "__bad_udelay" [drivers/scsi/bfa/bfa.ko] undefined!
> > which is a deliberately forced link error due to over large udelay
> > parameter (see also
> > http://osdir.com/ml/scm-fedora-commits/2014-01/msg14211.html)
> > 
> > I could do this for ARM only if you prefer, but in the first instance
> > that seemed like unnecessary faff..
> 
> Quite.
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> I have queued this in a branch of moderately-urgent stuff and will
> push it when the opportunity arises.

Thanks.

Patch

diff --git a/ts-kernel-build b/ts-kernel-build
index 9b92ffc..05d9e96 100755
--- a/ts-kernel-build
+++ b/ts-kernel-build
@@ -151,7 +151,7 @@  setopt CONFIG_SCSI_DC390T m
 setopt CONFIG_SCSI_NSP32 m
 setopt CONFIG_SCSI_PMCRAID m
 setopt CONFIG_SCSI_SRP m
-setopt CONFIG_SCSI_BFA_FC m
+setopt CONFIG_SCSI_BFA_FC n
 
 setopt CONFIG_MEGARAID_NEWGEN y
 setopt CONFIG_MEGARAID_MM m