| Message ID | 1600054147-29997-2-git-send-email-Anson.Huang@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [V2,RESEND,1/4] gpio: mxc: Support module build | expand |
On Mon, 14 Sep 2020 at 05:36, Anson Huang <Anson.Huang@nxp.com> wrote: > > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC > as built-in manually. Maybe it should stay not enabled? Please explain in commit msg why it should be enabled. Best regards, Krzysztof
Hi, Krzysztof > Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in > CONFIG_GPIO_MXC by default > > On Mon, 14 Sep 2020 at 05:36, Anson Huang <Anson.Huang@nxp.com> > wrote: > > > > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as > > built-in manually. > > Maybe it should stay not enabled? Please explain in commit msg why it should > be enabled. The CONFIG_GPIO_MXC is necessary for all the i.MX SoCs, as it provides the basic function of GPIO pin operations and IRQ operations, it is enabled by default previously with " def_bool y " in Kconfig, now it is changed to tristate, so it should be explicitly enabled in defconfig to make sure it does NOT break any existing functions, that is why I list " i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as built-in manually " in commit msg, it aims to NOT change any previous behaviors. thanks, Anson
On Wed, 16 Sep 2020 at 03:59, Anson Huang <anson.huang@nxp.com> wrote: > > Hi, Krzysztof > > > Subject: Re: [PATCH V2 RESEND 2/4] arm64: defconfig: Build in > > CONFIG_GPIO_MXC by default > > > > On Mon, 14 Sep 2020 at 05:36, Anson Huang <Anson.Huang@nxp.com> > > wrote: > > > > > > i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as > > > built-in manually. > > > > Maybe it should stay not enabled? Please explain in commit msg why it should > > be enabled. > > The CONFIG_GPIO_MXC is necessary for all the i.MX SoCs, as it provides the basic > function of GPIO pin operations and IRQ operations, it is enabled by default previously > with " def_bool y " in Kconfig, now it is changed to tristate, so it should be explicitly > enabled in defconfig to make sure it does NOT break any existing functions, that is > why I list " i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as > built-in manually " in commit msg, it aims to NOT change any previous behaviors. Sure, I was just saying that all this should be in commit msg. The commit should explain why it is there in the Linux kernel. Best regards, Krzysztof
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 63003ec..c8fca1a 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -510,6 +510,7 @@ CONFIG_GPIO_PCA953X=y CONFIG_GPIO_PCA953X_IRQ=y CONFIG_GPIO_BD9571MWV=m CONFIG_GPIO_MAX77620=y +CONFIG_GPIO_MXC=y CONFIG_POWER_AVS=y CONFIG_QCOM_CPR=y CONFIG_ROCKCHIP_IODOMAIN=y
i.MX GPIO is NOT default enabled now, so select CONFIG_GPIO_MXC as built-in manually. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- No change. --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)