diff mbox series

Input: elants_i2c - fix typo for an attribute to show calibration count

Message ID 1600238783-32303-1-git-send-email-johnny.chuang.emc@gmail.com
State Accepted
Commit 93f634069707cfe562c38739f5062feccbe9a834
Headers show
Series Input: elants_i2c - fix typo for an attribute to show calibration count | expand

Commit Message

Johnny Chuang Sept. 16, 2020, 6:46 a.m. UTC
Fixed typo for command from 0xE0 to 0xD0.

commit cf520c643012 ("Input: elants_i2c - provide an attribute
to show calibration count")

There is an non-touch case by non-calibration after update firmware.
Elan could know calibrate or not by calibration count.
The value of '0xffff' means we didn't calibrate after update firmware.
If calibrate success, it will plus one and change to '0x0000'.

Signed-off-by: Johnny Chuang <johnny.chuang.emc@gmail.com>
---
 drivers/input/touchscreen/elants_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Torokhov Sept. 16, 2020, 6:03 p.m. UTC | #1
On Wed, Sep 16, 2020 at 02:46:23PM +0800, Johnny Chuang wrote:
> Fixed typo for command from 0xE0 to 0xD0.

> 

> commit cf520c643012 ("Input: elants_i2c - provide an attribute

> to show calibration count")

> 

> There is an non-touch case by non-calibration after update firmware.

> Elan could know calibrate or not by calibration count.

> The value of '0xffff' means we didn't calibrate after update firmware.

> If calibrate success, it will plus one and change to '0x0000'.

> 

> Signed-off-by: Johnny Chuang <johnny.chuang.emc@gmail.com>


Applied, thank you.

-- 
Dmitry
diff mbox series

Patch

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index c8d7bdd..50c3482 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -90,7 +90,7 @@ 
 /* FW read command, 0x53 0x?? 0x0, 0x01 */
 #define E_ELAN_INFO_FW_VER	0x00
 #define E_ELAN_INFO_BC_VER	0x10
-#define E_ELAN_INFO_REK		0xE0
+#define E_ELAN_INFO_REK		0xD0
 #define E_ELAN_INFO_TEST_VER	0xE0
 #define E_ELAN_INFO_FW_ID	0xF0
 #define E_INFO_OSR		0xD6