| Message ID | 20200925231011.GA2450@agrajag.zerfleddert.de |
|---|---|
| State | New |
| Headers | show |
| Series | leds: tlc591xx: fix leak of device node iterator | expand |
On Sat, 26 Sep 2020 01:10:11 +0200 Tobias Jordan <kernel@cdqe.de> wrote: > In one of the error paths of the for_each_child_of_node loop in > tlc591xx_probe, add missing call to of_node_put. > > Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the > managed led API") > > Signed-off-by: Tobias Jordan <kernel@cdqe.de> > --- > drivers/leds/leds-tlc591xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c > index 0929f1275814..a8cc49752cd5 100644 > --- a/drivers/leds/leds-tlc591xx.c > +++ b/drivers/leds/leds-tlc591xx.c > @@ -214,6 +214,7 @@ tlc591xx_probe(struct i2c_client *client, > err = devm_led_classdev_register_ext(dev, &led->ldev, > &init_data); > if (err < 0) { > + of_node_put(child); > if (err != -EPROBE_DEFER) > dev_err(dev, "couldn't register LED %s\n", > led->ldev.name); This won't apply on pavel's for-next tree, there is no check for EPROBE_DEFER, see https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/tree/drivers/leds/leds-tlc591xx.c?h=for-next
diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c index 0929f1275814..a8cc49752cd5 100644 --- a/drivers/leds/leds-tlc591xx.c +++ b/drivers/leds/leds-tlc591xx.c @@ -214,6 +214,7 @@ tlc591xx_probe(struct i2c_client *client, err = devm_led_classdev_register_ext(dev, &led->ldev, &init_data); if (err < 0) { + of_node_put(child); if (err != -EPROBE_DEFER) dev_err(dev, "couldn't register LED %s\n", led->ldev.name);
In one of the error paths of the for_each_child_of_node loop in tlc591xx_probe, add missing call to of_node_put. Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the managed led API") Signed-off-by: Tobias Jordan <kernel@cdqe.de> --- drivers/leds/leds-tlc591xx.c | 1 + 1 file changed, 1 insertion(+)