| Message ID | 20200922190638.5323-2-dmurphy@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Tue, 22 Sep 2020 14:06:38 -0500 Dan Murphy <dmurphy@ti.com> wrote: > Fix warnings for undefined parameters when building with W=1. > > Fixes: 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver") > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > drivers/leds/leds-lm36274.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c > index 10a63b7f2ecc..bf6487e9a1f4 100644 > --- a/drivers/leds/leds-lm36274.c > +++ b/drivers/leds/leds-lm36274.c > @@ -26,8 +26,8 @@ > * @lmu_data: Register and setting values for common code > * @regmap: Devices register map > * @dev: Pointer to the devices device struct > - * @led_sources - The LED strings supported in this array > - * @num_leds - Number of LED strings are supported in this array > + * @led_sources: The LED strings supported in this array > + * @num_leds: Number of LED strings are supported in this array > */ > struct lm36274 { > struct platform_device *pdev; > @@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = { > .probe = lm36274_probe, > .driver = { > .name = "lm36274-leds", > + .of_match_table = of_lm36274_leds_match, > }, > }; > module_platform_driver(lm36274_driver) Reviewed-by: Marek Behún <kabel@kernel.org>
On Tue 2020-09-22 14:06:38, Dan Murphy wrote: > Fix warnings for undefined parameters when building with W=1. > It also adds of_match_table. I guess that's okay. I'll remove the fixes tags as I don't believe these need to go to stable. Best regards, Pavel > Fixes: 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver") > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > drivers/leds/leds-lm36274.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c > index 10a63b7f2ecc..bf6487e9a1f4 100644 > --- a/drivers/leds/leds-lm36274.c > +++ b/drivers/leds/leds-lm36274.c > @@ -26,8 +26,8 @@ > * @lmu_data: Register and setting values for common code > * @regmap: Devices register map > * @dev: Pointer to the devices device struct > - * @led_sources - The LED strings supported in this array > - * @num_leds - Number of LED strings are supported in this array > + * @led_sources: The LED strings supported in this array > + * @num_leds: Number of LED strings are supported in this array > */ > struct lm36274 { > struct platform_device *pdev; > @@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = { > .probe = lm36274_probe, > .driver = { > .name = "lm36274-leds", > + .of_match_table = of_lm36274_leds_match, > }, > }; > module_platform_driver(lm36274_driver) > -- > 2.28.0 -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c index 10a63b7f2ecc..bf6487e9a1f4 100644 --- a/drivers/leds/leds-lm36274.c +++ b/drivers/leds/leds-lm36274.c @@ -26,8 +26,8 @@ * @lmu_data: Register and setting values for common code * @regmap: Devices register map * @dev: Pointer to the devices device struct - * @led_sources - The LED strings supported in this array - * @num_leds - Number of LED strings are supported in this array + * @led_sources: The LED strings supported in this array + * @num_leds: Number of LED strings are supported in this array */ struct lm36274 { struct platform_device *pdev; @@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = { .probe = lm36274_probe, .driver = { .name = "lm36274-leds", + .of_match_table = of_lm36274_leds_match, }, }; module_platform_driver(lm36274_driver)
Fix warnings for undefined parameters when building with W=1. Fixes: 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver") Signed-off-by: Dan Murphy <dmurphy@ti.com> --- drivers/leds/leds-lm36274.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)