diff mbox series

leds: disallow /sys/class/leds/*:multi:* for now

Message ID 20200803120222.3x3irmbmomebkfqw@duo.ucw.cz
State New
Headers show
Series leds: disallow /sys/class/leds/*:multi:* for now | expand

Commit Message

Pavel Machek Aug. 3, 2020, 12:02 p.m. UTC
commit 77dce3a22e8941552a15046d4113df9ce132fb3d
Author: Pavel Machek <pavel@ucw.cz>
Date:   Mon Aug 3 14:00:06 2020 +0200

    leds: disallow /sys/class/leds/*:multi:* for now
    
    All the LEDs in the queue are RGB, so they should not use multi for
    their color.
    
    Make sure we don't add such LED by mistake (and make it part of ABI).
    
    Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff mbox series

Patch

diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
index a6dce01dbd5e..c4e780bdb385 100644
--- a/drivers/leds/led-core.c
+++ b/drivers/leds/led-core.c
@@ -425,6 +425,10 @@  int led_compose_name(struct device *dev, struct led_init_data *init_data,
 	struct fwnode_handle *fwnode = init_data->fwnode;
 	const char *devicename = init_data->devicename;
 
+	/* We want to label LEDs that can produce full range of colors
+	 * as RGB, not multicolor */
+	BUG_ON(props.color == LED_COLOR_ID_MULTI);
+
 	if (!led_classdev_name)
 		return -EINVAL;