| Message ID | 20200825220437.11214-1-anant.thazhemadam@gmail.com |
|---|---|
| State | Accepted |
| Commit | a4f3761771bc45ab433bd38fd437bb2e40617f27 |
| Headers | show |
| Series | staging: media-atomisp : fix "dubious: !x | !y" sparse warning | expand |
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c index 358cb7d2cd4c..3b850bb2d39d 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c @@ -58,7 +58,7 @@ sh_css_vf_downscale_log2( unsigned int ds_log2 = 0; unsigned int out_width; - if ((!out_info) | (!vf_info)) + if ((!out_info) || (!vf_info)) return -EINVAL; out_width = out_info->res.width;
Upon running sparse, "warning: dubious: !x | !y" is brought to notice for this file. This patch fixes that warning. If there's a specific reason that this change is considered undesirable, please do let me know why. Thanks. Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com> --- .../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)