| Message ID | 20200823140846.19299-5-digetx@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
09.09.2020 00:53, Rob Herring пишет: ... >> Alright, I don't mind to separate the bindings. Although, before doing >> that, I'd want to get opinion from the device-tree experts, i.e. from >> Rob Herring :) >> >> Rob, will it be fine to have separate bindings for each firmware version >> of the ENE controller given that firmware is individual for every device >> and given that FW has no compatibility with other devices? > > Seems like separate bindings makes sense here. Okay, thank you for the answers and for the review of the v3!
diff --git a/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml index 074243c40891..5a1c4a959d9c 100644 --- a/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml +++ b/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml @@ -17,8 +17,11 @@ properties: compatible: items: - enum: + - acer,a500-iconia-ec # Acer A500 Iconia tablet device - dell,wyse-ariel-ec # Dell Wyse Ariel board (3020) - - const: ene,kb3930 + - enum: + - ene,kb3930 + - ene,kb930 reg: maxItems: 1
The ENE KB930 hardware is compatible with KB3930. Acer A500 Iconia Tab is Android tablet device, it has KB930 controller that is running firmware specifically customized for the needs of the Acer A500 hardware. This means that firmware interface isn't re-usable by other non-Acer devices. Some akin models of Acer tablets should be able to re-use the FW interface of A500 model, like A200 for example. This patch adds the new compatibles to the binding. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- Documentation/devicetree/bindings/mfd/ene-kb3930.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)