[LNG] Fix ltp realtime hrtimer-prio and measurement to pass default profile to run_c_files.sh

Message ID 1394464444-23803-1-git-send-email-ciprian.barbu@linaro.org
State Accepted
Commit 79c6f33cd8c2c473de1fb7afc98e92ac59f93aa9
Headers show

Commit Message

Ciprian Barbu March 10, 2014, 3:14 p.m.
Signed-off-by: Ciprian Barbu <ciprian.barbu@linaro.org>

Upstream-Status: Pending
---
 testcases/realtime/func/hrtimer-prio/run_auto.sh |    4 +++-
 testcases/realtime/func/measurement/run_auto.sh  |    6 ++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

Comments

Ciprian Barbu March 21, 2014, 10:49 a.m. | #1
Hello,

On 10.03.2014 17:14, Ciprian Barbu wrote:
> Signed-off-by: Ciprian Barbu <ciprian.barbu@linaro.org>
>
> Upstream-Status: Pending
> ---
>   testcases/realtime/func/hrtimer-prio/run_auto.sh |    4 +++-
>   testcases/realtime/func/measurement/run_auto.sh  |    6 ++++--
>   2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/realtime/func/hrtimer-prio/run_auto.sh b/testcases/realtime/func/hrtimer-prio/run_auto.sh
> index 366e746..ec3d83a 100644
> --- a/testcases/realtime/func/hrtimer-prio/run_auto.sh
> +++ b/testcases/realtime/func/hrtimer-prio/run_auto.sh
> @@ -1,5 +1,7 @@
>   #! /bin/bash
>
> +profile=${1:-default}
> +
>   if [ ! $SCRIPTS_DIR ]; then
>           # assume we're running standalone
>           export SCRIPTS_DIR=../../scripts/
> @@ -7,4 +9,4 @@ fi
>
>   source $SCRIPTS_DIR/setenv.sh
>
> -$SCRIPTS_DIR/run_c_files.sh "hrtimer-prio"
> +$SCRIPTS_DIR/run_c_files.sh $profile "hrtimer-prio"
> diff --git a/testcases/realtime/func/measurement/run_auto.sh b/testcases/realtime/func/measurement/run_auto.sh
> index 3011964..439f721 100644
> --- a/testcases/realtime/func/measurement/run_auto.sh
> +++ b/testcases/realtime/func/measurement/run_auto.sh
> @@ -1,5 +1,7 @@
>   #! /bin/bash
>
> +profile=${1:-default}
> +
>   if [ ! $SCRIPTS_DIR ]; then
>           # assume we're running standalone
>           export SCRIPTS_DIR=../../scripts/
> @@ -13,7 +15,7 @@ source $SCRIPTS_DIR/setenv.sh
>   # issues right now.
>
>   LOG_FILE="$LOG_DIR/$LOG_FORMAT-rdtsc-latency.log"
> -$SCRIPTS_DIR/run_c_files.sh "rdtsc-latency"
> +$SCRIPTS_DIR/run_c_files.sh $profile "rdtsc-latency"
>
>   LOG_FILE="$LOG_DIR/$LOG_FORMAT-preempt_timing.log"
> -$SCRIPTS_DIR/run_c_files.sh "preempt_timing"
> +$SCRIPTS_DIR/run_c_files.sh $profile "preempt_timing"
>

Sorry if I'm being insistent, has anyone got the chance to look at this 
patch? I would like to know if it can be applied to master.

Kind regards,
Ciprian
Cyril Hrubis March 24, 2014, 2:24 p.m. | #2
Hi!
> Sorry if I'm being insistent, has anyone got the chance to look at this 
> patch? I would like to know if it can be applied to master.

Sorry not yet. I will hopefully get to it this week.
Cyril Hrubis March 26, 2014, 3:44 p.m. | #3
Hi!
> Signed-off-by: Ciprian Barbu <ciprian.barbu@linaro.org>
> 
> Upstream-Status: Pending

Pushed with splitting the long line in the commit log.

The log should be in format:

short description

rest of the description that can span to several lines

Signed-off-by: ...
Ciprian Barbu March 27, 2014, 12:13 p.m. | #4
Hi,

On Wed, Mar 26, 2014 at 5:44 PM, <chrubis@suse.cz> wrote:

> Hi!
> > Signed-off-by: Ciprian Barbu <ciprian.barbu@linaro.org>
> >
> > Upstream-Status: Pending
>
> Pushed with splitting the long line in the commit log.
>
> The log should be in format:
>
> short description
>

Sorry about that and thank you!

>
> rest of the description that can span to several lines
>
> Signed-off-by: ...
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>

/Ciprian
------------------------------------------------------------------------------

Patch

diff --git a/testcases/realtime/func/hrtimer-prio/run_auto.sh b/testcases/realtime/func/hrtimer-prio/run_auto.sh
index 366e746..ec3d83a 100644
--- a/testcases/realtime/func/hrtimer-prio/run_auto.sh
+++ b/testcases/realtime/func/hrtimer-prio/run_auto.sh
@@ -1,5 +1,7 @@ 
 #! /bin/bash
 
+profile=${1:-default}
+
 if [ ! $SCRIPTS_DIR ]; then
         # assume we're running standalone
         export SCRIPTS_DIR=../../scripts/
@@ -7,4 +9,4 @@  fi
 
 source $SCRIPTS_DIR/setenv.sh
 
-$SCRIPTS_DIR/run_c_files.sh "hrtimer-prio"
+$SCRIPTS_DIR/run_c_files.sh $profile "hrtimer-prio"
diff --git a/testcases/realtime/func/measurement/run_auto.sh b/testcases/realtime/func/measurement/run_auto.sh
index 3011964..439f721 100644
--- a/testcases/realtime/func/measurement/run_auto.sh
+++ b/testcases/realtime/func/measurement/run_auto.sh
@@ -1,5 +1,7 @@ 
 #! /bin/bash
 
+profile=${1:-default}
+
 if [ ! $SCRIPTS_DIR ]; then
         # assume we're running standalone
         export SCRIPTS_DIR=../../scripts/
@@ -13,7 +15,7 @@  source $SCRIPTS_DIR/setenv.sh
 # issues right now.
 
 LOG_FILE="$LOG_DIR/$LOG_FORMAT-rdtsc-latency.log"
-$SCRIPTS_DIR/run_c_files.sh "rdtsc-latency"
+$SCRIPTS_DIR/run_c_files.sh $profile "rdtsc-latency"
 
 LOG_FILE="$LOG_DIR/$LOG_FORMAT-preempt_timing.log"
-$SCRIPTS_DIR/run_c_files.sh "preempt_timing"
+$SCRIPTS_DIR/run_c_files.sh $profile "preempt_timing"