| Message ID | 1394468977-23149-1-git-send-email-broonie@kernel.org |
|---|---|
| State | New |
| Headers | show |
> From: Mark Brown <broonie@linaro.org> > > During init the core checks if the wm5102 has finished starting by reading > register 0x19 and looking at the value. This read always fails since this > is not a readable register, mark it as being one. > > Signed-off-by: Mark Brown <broonie@linaro.org> > --- > drivers/mfd/wm5102-tables.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c > index f4668d39e542..07f024fd4ded 100644 > --- a/drivers/mfd/wm5102-tables.c > +++ b/drivers/mfd/wm5102-tables.c > @@ -1016,6 +1016,7 @@ static bool wm5102_readable_register(struct device *dev, unsigned int reg) > case ARIZONA_WRITE_SEQUENCER_CTRL_0: > case ARIZONA_WRITE_SEQUENCER_CTRL_1: > case ARIZONA_WRITE_SEQUENCER_CTRL_2: > + case 0x19: Can we have a #define for these please? > case ARIZONA_WRITE_SEQUENCER_PROM: > case ARIZONA_TONE_GENERATOR_1: > case ARIZONA_TONE_GENERATOR_2:
On Mon, Mar 10, 2014 at 04:38:11PM +0000, Lee Jones wrote:
> Can we have a #define for these please?
It'd be nice but you'd need to ask the Wolfson guys to tell us what it's
called, all the information I have is the read in the driver source.
Meanwile we've got a bug.
diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c index f4668d39e542..07f024fd4ded 100644 --- a/drivers/mfd/wm5102-tables.c +++ b/drivers/mfd/wm5102-tables.c @@ -1016,6 +1016,7 @@ static bool wm5102_readable_register(struct device *dev, unsigned int reg) case ARIZONA_WRITE_SEQUENCER_CTRL_0: case ARIZONA_WRITE_SEQUENCER_CTRL_1: case ARIZONA_WRITE_SEQUENCER_CTRL_2: + case 0x19: case ARIZONA_WRITE_SEQUENCER_PROM: case ARIZONA_TONE_GENERATOR_1: case ARIZONA_TONE_GENERATOR_2: