From patchwork Wed Mar 12 04:18:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inderpal Singh X-Patchwork-Id: 26074 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f71.google.com (mail-oa0-f71.google.com [209.85.219.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 64EEF202E1 for ; Wed, 12 Mar 2014 04:24:33 +0000 (UTC) Received: by mail-oa0-f71.google.com with SMTP id j17sf37768647oag.6 for ; Tue, 11 Mar 2014 21:24:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:from:to:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type; bh=0mi1vWP8quOlDvEo5UQKgKTGnicpcLaiEGgZUD0Qfz0=; b=QYKVM7rYckzuzGjlevV8NOY9Q4kOYjW4s2IxGx+cy3g+yj3xgNtkCuYxNh9c0WdtHL 9/im5Dndww5RR+0LZ3A9I18+kb5gjStiiiM3+hLTMphdTUV8x5mgCMil5vcqHKhJkNOr GiXpOYihQniWG9nCOzV98sg5oSEMLDkT7i0SRin7ZrMzbZhoQFQWPWMeuImHqMpt56/j Dnau26AaTI4scs7EQ+y+e5Q+gYdQfu9Efp/SiOHz6AApFYzolYHeACrtVz2iCYyiOfly dnW1Wk0xzgyj7e116ZE7LoFCAaDvNgQuHeGf3Y1l3w8txGm4Wjsx3DUWqc0Zp8P69TBL phZw== X-Gm-Message-State: ALoCoQmaqHlxQlpP2YAlh+gQJ+RzmV1JGYbpQzp66h8EIkuSmUglIp1TNOPPNyJ/F7xtWbIX/8j0 X-Received: by 10.50.129.74 with SMTP id nu10mr11609600igb.7.1394598273059; Tue, 11 Mar 2014 21:24:33 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.102.1 with SMTP id v1ls2830556qge.50.gmail; Tue, 11 Mar 2014 21:24:32 -0700 (PDT) X-Received: by 10.58.220.161 with SMTP id px1mr31416607vec.13.1394598272904; Tue, 11 Mar 2014 21:24:32 -0700 (PDT) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id ue9si6482276veb.54.2014.03.11.21.24.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 11 Mar 2014 21:24:32 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id im17so2589465vcb.23 for ; Tue, 11 Mar 2014 21:24:32 -0700 (PDT) X-Received: by 10.58.253.6 with SMTP id zw6mr1090988vec.20.1394598272808; Tue, 11 Mar 2014 21:24:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp258761vck; Tue, 11 Mar 2014 21:24:32 -0700 (PDT) X-Received: by 10.205.14.72 with SMTP id pp8mr5111517bkb.6.1394598271343; Tue, 11 Mar 2014 21:24:31 -0700 (PDT) Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id uh6si7877444bkb.157.2014.03.11.21.24.30 for ; Tue, 11 Mar 2014 21:24:31 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) client-ip=85.214.87.163; Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 57C734B5CB; Wed, 12 Mar 2014 05:24:30 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mYdqGyLqPZFt; Wed, 12 Mar 2014 05:24:30 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D0AE74B199; Wed, 12 Mar 2014 05:24:27 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8CA854B199 for ; Wed, 12 Mar 2014 05:24:23 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DT-4us2Kwh6j for ; Wed, 12 Mar 2014 05:24:20 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by theia.denx.de (Postfix) with ESMTPS id 387E64B174 for ; Wed, 12 Mar 2014 05:24:16 +0100 (CET) Received: by mail-wi0-f173.google.com with SMTP id f8so1824148wiw.12 for ; Tue, 11 Mar 2014 21:24:16 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.164.174 with SMTP id yr14mr5697712wib.18.1394597905622; Tue, 11 Mar 2014 21:18:25 -0700 (PDT) Received: by 10.194.41.133 with HTTP; Tue, 11 Mar 2014 21:18:25 -0700 (PDT) In-Reply-To: <4B0B8DCC-07C3-4C50-8047-B868A0DDC014@gmail.com> References: <4B0B8DCC-07C3-4C50-8047-B868A0DDC014@gmail.com> Date: Wed, 12 Mar 2014 09:48:25 +0530 Message-ID: From: Inderpal Singh To: armdev X-Content-Filtered-By: Mailman/MimeDel 2.1.11 Cc: "trini@ti.com" , "u-boot@lists.denx.de" , p.marczak@samsung.com Subject: Re: [U-Boot] usb start crashing on arndale X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: inderpal.singh@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Hi, On 11 March 2014 20:25, armdev wrote: > Adding Inderpal singh and Trini. Please help > > On 11-Mar-2014, at 12:27 pm, armdev wrote: > > > Hi, > > > > We have recently started working on arndale and running u-boot head on > it. Seems like it is crashing on our setup with a data abort on usb start. > Can anyone please confirm and suggest a fix / solution > > > > U-Boot 2014.04-rc1-00486-geeb72e6 (Mar 11 2014 - 11:44:32) for ARNDALE > > > > CPU: Exynos5250@1000MHz > > > > Board: Arndale > > I2C: i2c_init: failed to init bus 0 for speed = 100000 > > ready > > DRAM: 2 GiB > > trace: copying 00084f98 bytes of early data from 50000000 to beff0000 > > trace: enabled > > WARNING: Caches not enabled > > MMC: EXYNOS DWMMC: 0, EXYNOS DWMMC: 1 > > i2c_init: failed to init bus 0 for speed = 100000 > > In: serial > > Out: serial > > Err: serial > > Net: Net Initialization Skipped > > No ethernet found. > > Hit any key to stop autoboot: 0 > > ARNDALE # usb start > > (Re)start USB... > > USB0: data abort > > pc : [] lr : [] > > sp : beb5f9c0 ip : 00000003 fp : 00000000 > > r10: 00000000 r9 : beb62ecc r8 : befbcc80 > > r7 : befbcc84 r6 : 0000ffff r5 : 000000ff r4 : 00000001 > > r3 : 00000000 r2 : 00000001 r1 : 000000ff r0 : 0000ffff > > Flags: nzCv IRQs off FIQs off Mode SVC_32 > > Resetting CPU ... > > > > > I was able to reproduce the issue and git bisect tells me that it started happening after the commit "8475c86 s5p: gpio: change gpio coding method for s5p gpio". Upon debugging further I figured out that it happens because the function fdtdec_setup_gpio returns success even if there is no gpio defined. Since no error is returned the exynos ehci driver goes ahead to setup the gpio and data abort happens. If I return failure from this function it works well. defined. Simon, could you please suggest where do we need to fix it ? the above function or gpio driver ? Thanks, Inder > > Thanks and Regards > > Armdev@FTM Team > > > > diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 1fecab3..b1c4e92 100644 --- a/lib/fdtdec.c +++ b/lib/fdtdec.c @@ -526,7 +526,7 @@ int fdtdec_setup_gpio(struct fdt_gpio_state *gpio) * optional GPIOs) */ if (!fdt_gpio_isvalid(gpio)) - return 0; + return -1; I am not sure of the objective to return success if there is no gpio