diff mbox series

hsr: avoid newline at end of message in NL_SET_ERR_MSG_MOD

Message ID 20200909093821.54820-1-yebin10@huawei.com
State New
Headers show
Series hsr: avoid newline at end of message in NL_SET_ERR_MSG_MOD | expand

Commit Message

Ye Bin Sept. 9, 2020, 9:38 a.m. UTC 
clean follow coccicheck warning:
net//hsr/hsr_netlink.c:94:8-42: WARNING avoid newline at end of message
in NL_SET_ERR_MSG_MOD
net//hsr/hsr_netlink.c:87:30-57: WARNING avoid newline at end of message
in NL_SET_ERR_MSG_MOD
net//hsr/hsr_netlink.c:79:29-53: WARNING avoid newline at end of message
in NL_SET_ERR_MSG_MOD

Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 net/hsr/hsr_netlink.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

David Miller Sept. 9, 2020, 6:16 p.m. UTC | #1 
From: Ye Bin <yebin10@huawei.com>
Date: Wed, 9 Sep 2020 17:38:21 +0800

> clean follow coccicheck warning:
> net//hsr/hsr_netlink.c:94:8-42: WARNING avoid newline at end of message
> in NL_SET_ERR_MSG_MOD
> net//hsr/hsr_netlink.c:87:30-57: WARNING avoid newline at end of message
> in NL_SET_ERR_MSG_MOD
> net//hsr/hsr_netlink.c:79:29-53: WARNING avoid newline at end of message
> in NL_SET_ERR_MSG_MOD
> 
> Signed-off-by: Ye Bin <yebin10@huawei.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/net/hsr/hsr_netlink.c b/net/hsr/hsr_netlink.c
index 06c3cd988760..0e4681cf71db 100644
--- a/net/hsr/hsr_netlink.c
+++ b/net/hsr/hsr_netlink.c
@@ -76,7 +76,7 @@  static int hsr_newlink(struct net *src_net, struct net_device *dev,
 		proto = nla_get_u8(data[IFLA_HSR_PROTOCOL]);
 
 	if (proto >= HSR_PROTOCOL_MAX) {
-		NL_SET_ERR_MSG_MOD(extack, "Unsupported protocol\n");
+		NL_SET_ERR_MSG_MOD(extack, "Unsupported protocol");
 		return -EINVAL;
 	}
 
@@ -84,14 +84,14 @@  static int hsr_newlink(struct net *src_net, struct net_device *dev,
 		proto_version = HSR_V0;
 	} else {
 		if (proto == HSR_PROTOCOL_PRP) {
-			NL_SET_ERR_MSG_MOD(extack, "PRP version unsupported\n");
+			NL_SET_ERR_MSG_MOD(extack, "PRP version unsupported");
 			return -EINVAL;
 		}
 
 		proto_version = nla_get_u8(data[IFLA_HSR_VERSION]);
 		if (proto_version > HSR_V1) {
 			NL_SET_ERR_MSG_MOD(extack,
-					   "Only HSR version 0/1 supported\n");
+					   "Only HSR version 0/1 supported");
 			return -EINVAL;
 		}
 	}