diff mbox series

[net-next] net: ethernet: dnet: Remove set but unused variable 'len'

Message ID 20200907141207.11778-1-wanghai38@huawei.com
State New
Headers show
Series [net-next] net: ethernet: dnet: Remove set but unused variable 'len' | expand

Commit Message

Wang Hai Sept. 7, 2020, 2:12 p.m. UTC
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/dnet.c: In function dnet_start_xmit
drivers/net/ethernet/dnet.c:511:15: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]

commit 4796417417a6 ("dnet: Dave DNET ethernet controller driver (updated)")
involved this unused variable, remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
 drivers/net/ethernet/dnet.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Jakub Kicinski Sept. 7, 2020, 8:58 p.m. UTC | #1
On Mon, 7 Sep 2020 22:12:07 +0800 Wang Hai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/dnet.c: In function dnet_start_xmit
> drivers/net/ethernet/dnet.c:511:15: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]
> 
> commit 4796417417a6 ("dnet: Dave DNET ethernet controller driver (updated)")
> involved this unused variable, remove it.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>

tx_status is also not used. But I guess one change per commit, 
so applied. Thanks!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/dnet.c b/drivers/net/ethernet/dnet.c
index db98274501a0..3143df9a398c 100644
--- a/drivers/net/ethernet/dnet.c
+++ b/drivers/net/ethernet/dnet.c
@@ -508,7 +508,7 @@  static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
 
 	struct dnet *bp = netdev_priv(dev);
 	u32 tx_status, irq_enable;
-	unsigned int len, i, tx_cmd, wrsz;
+	unsigned int i, tx_cmd, wrsz;
 	unsigned long flags;
 	unsigned int *bufp;
 
@@ -518,9 +518,6 @@  static netdev_tx_t dnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
 	       skb->len, skb->head, skb->data);
 	dnet_print_skb(skb);
 
-	/* frame size (words) */
-	len = (skb->len + 3) >> 2;
-
 	spin_lock_irqsave(&bp->lock, flags);
 
 	tx_status = dnet_readl(bp, TX_STATUS);